Closed
Bug 477792
Opened 17 years ago
Closed 16 years ago
Clean up hgpoller.py
Categories
(Release Engineering :: General, defect, P2)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Pike, Assigned: coop)
References
Details
Attachments
(1 file)
|
3.90 KB,
patch
|
anodelman
:
review+
Pike
:
review+
coop
:
checked-in+
|
Details | Diff | Splinter Review |
After landing bug 464163, we should do some further clean up on hgpoller.py:
More docstrings would be good, ThrottleGetPage can be removed, __all__ should reflect the export of hgpoller and not the ones of the date parsing routines we imported. We should probably add a license header, too.
|
Assignee | |
Updated•17 years ago
|
Assignee: nobody → ccooper
Priority: -- → P3
|
|
Assignee | |
Updated•16 years ago
|
Status: NEW → ASSIGNED
Priority: P3 → P2
|
|
Assignee | |
Comment 1•16 years ago
|
||
I didn't add any new docstrings because some have already been added since this bug was filed. Are there any functions/classes that still need them?
Attachment #370709 -
Flags: review?(l10n)
|
|
Assignee | |
Updated•16 years ago
|
Attachment #370709 -
Flags: review?(l10n) → review?(anodelman)
|
||
Updated•16 years ago
|
Attachment #370709 -
Flags: review?(anodelman) → review+
|
Reporter | |
Comment 2•16 years ago
|
||
Comment on attachment 370709 [details] [diff] [review]
Add license header, make __all__ more complete, remove ThrottleGetPage
oops, sorry. Yeah, totally r+.
Attachment #370709 -
Flags: review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Comment on attachment 370709 [details] [diff] [review]
Add license header, make __all__ more complete, remove ThrottleGetPage
(In reply to comment #2)
> (From update of attachment 370709 [details] [diff] [review])
> oops, sorry. Yeah, totally r+.
No worries, just trying to get some stuff off your plate.
Landed and reconfig-ed.
changeset: 256:fe254d49f952
Attachment #370709 -
Flags: checked‑in+ checked‑in+
|
|
Assignee | |
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•