Closed Bug 477793 Opened 15 years ago Closed 15 years ago

Make sure preventive maintenance cannot act on roots

Categories

(Toolkit :: Places, defect, P1)

Product:
Toolkit
Component:
Places
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: mak, Assigned: mak)

References

Details

(Keywords: verified1.9.1)

Attachments

(1 file)

patch v1.0
9.66 KB, patch
sdwilsh
: review+
Details | Diff | Splinter Review
Attached patch patch v1.0 — — Splinter Review 
bug 477739 shows a case where preventive maintenance in an unexpected situation could move roots, as an additional level of protection we should filter out them.
I checked that actually there's no way preventive maintenance could cause harm to roots, but if something other causes an un-coherence on them, we could end up doing more damage.

I think, while investigating on bug 477739 original causes, we should take this asap on both trunk and branch, and possibly for b3.
Flags: blocking1.9.1?
Attachment #361506 - Flags: review?(dietrich)
Priority: -- → P1
Blocks: 477739
Severity: normal → critical
OS: Windows Vista → All
Hardware: x86 → All
Attachment #361506 - Flags: review?(dietrich) → review+
Comment on attachment 361506 [details] [diff] [review]
patch v1.0

r=sdwilsh
extra-defensive protection of user data ftw, blocking+.
Flags: blocking1.9.1? → blocking1.9.1+
Assignee: nobody → mak77
Status: NEW → ASSIGNED
http://hg.mozilla.org/mozilla-central/rev/309fe2e46ebd
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Verified by the fact that the problem hasn't been occurred again on this ppc machine. Seems to be fine.
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in before you can comment on or make changes to this bug.