Closed Bug 477959 Opened 16 years ago Closed 16 years ago

fix uninitialized memory read in nsScreenManager shutdown

Categories

(Core :: Widget: Gtk, defect, P3)

All
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Keywords: valgrind)

Attachments

(1 file)

Attached patch patchSplinter Review
I noticed a valgrind warning recently when shutting down: we're reading unitialized memory in nsScreenManager. The problem is that numScreens is uninitialized in some cases. This patch fixes the problem by only changing mXineramaIsActive from its initial false value when numScreens is initialized.
Attachment #361711 - Flags: superreview?(roc)
Attachment #361711 - Flags: review?(roc)
Attachment #361711 - Flags: superreview?(roc)
Attachment #361711 - Flags: superreview+
Attachment #361711 - Flags: review?(roc)
Attachment #361711 - Flags: review+
Flags: in-testsuite+
Keywords: valgrind
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Priority: -- → P3
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: