478023 - crash [@ nsNavHistory::CalculateFrecency]

Status: RESOLVED WORKSFORME

(Toolkit :: Places, defect)

Description

[Samuel Sidler (old account; do not CC)]

The current #6 topcrash on the 1.9.1 branch (Firefox 3.1b3) happens at nsNavHistory::CalculateFrecency(__int64, int, int, nsCAutoString&, int*)

Right now, it looks like it's only happening on Windows, but who knows how accurate that is (there's only 68 crashes in the last week). This also appears to be a crash on startup or shortly after, based on the uptime of the crashes (all under 30 seconds). There are no comments for the currently reported crash reports.

This is a new crash that doesn't appear on the 1.9.0 branch.

Sample crash report from bp-4104ab81-2f3a-4608-8245-fe0942090211:

Frame  	Module  	Signature [Expand]  	Source
0 		@0x30200 	
1 	xul.dll 	nsNavHistory::CalculateFrecency 	toolkit/components/places/src/nsNavHistory.cpp:7148
2 	xul.dll 	nsNavHistory::RecalculateFrecenciesInternal 	toolkit/components/places/src/nsNavHistory.cpp:7200
3 	xul.dll 	nsNavHistory::RecalculateFrecencies 	toolkit/components/places/src/nsNavHistory.cpp:7162
4 	xul.dll 	nsNavHistory::Init 	toolkit/components/places/src/nsNavHistory.cpp:550
5 	xul.dll 	nsNavHistory::GetSingleton 	toolkit/components/places/src/nsNavHistory.cpp:358
6 	xul.dll 	nsNavHistoryConstructor 	toolkit/components/places/src/nsPlacesModule.cpp:19
7 	xul.dll 	nsGenericFactory::CreateInstance 	obj-firefox/xpcom/build/nsGenericFactory.cpp:80
8 	xul.dll 	nsComponentManagerImpl::CreateInstanceByContractID 	xpcom/components/nsComponentManager.cpp:1686
9 	xul.dll 	nsComponentManagerImpl::GetServiceByContractID 	xpcom/components/nsComponentManager.cpp:2253
10 	xul.dll 	CallGetService 	obj-firefox/xpcom/build/nsComponentManagerUtils.cpp:94
11 	xul.dll 	nsCOMPtr_base::assign_from_gs_contractid 	obj-firefox/xpcom/build/nsCOMPtr.cpp:132
12 	xul.dll 	nsCOMPtr<nsINavHistoryService>::nsCOMPtr<nsINavHistoryService> 	obj-firefox/dist/include/xpcom/nsCOMPtr.h:604
13 	xul.dll 	nsNavHistory::GetHistoryService 	toolkit/components/places/src/nsNavHistory.h:195
14 	xul.dll 	nsNavBookmarks::Init 	toolkit/components/places/src/nsNavBookmarks.cpp:110
15 	xul.dll 	nsNavBookmarksConstructor 	toolkit/components/places/src/nsPlacesModule.cpp:23
16 	xul.dll 	nsGenericFactory::CreateInstance 	obj-firefox/xpcom/build/nsGenericFactory.cpp:80
17 	xul.dll 	nsComponentManagerImpl::CreateInstance 	xpcom/components/nsComponentManager.cpp:1600
18 	xul.dll 	xul.dll@0x95df7f

See also: http://crash-stats.mozilla.com/report/list?product=Firefox&version=Firefox%3A3.1b3pre&query_search=signature&query_type=contains&query=&date=&range_value=1&range_unit=weeks&do_query=1&signature=nsNavHistory%3A%3ACalculateFrecency(__int64%2C%20int%2C%20int%2C%20nsCAutoString%26%2C%20int*)

Comment 1

[Marco Bonardo [:mak]]

this:
3     xul.dll     nsNavHistory::RecalculateFrecencies    
toolkit/components/places/src/nsNavHistory.cpp:7162
4     xul.dll     nsNavHistory::Init    
toolkit/components/places/src/nsNavHistory.cpp:550

makes me think bug 476292 could have fixed this as well, need to check if are there crashes from the day after 2009-02-03 19:03:49 (when that was pushed)

Comment 2

[Shawn Wilsher :sdwilsh]

Are these old builds?  The stacks look similar to bug 476292, and the stacks don't mesh with the code (we don't call RecalculateFrecencies in Init anymore):
http://mxr.mozilla.org/mozilla1.9.1/source/toolkit/components/places/src/nsNavHistory.cpp#550

Comment 3

[Samuel Sidler (old account; do not CC)]

O hai, they are. Nevermind me.

Comment 4

[Samuel Sidler (old account; do not CC)]

(Note: Using my link in comment 0 -- after being properly formed -- you can click on "Table" to see which build IDs are reporting it. I filed in haste and didn't pay close enough attention.)

Comment 5

[Marco Bonardo [:mak]]

yes, i've checked and all builds are before 03 Feb, when that fix was pushed. thanks!