47826 - defined(%hash) is deprecated

Status: VERIFIED DUPLICATE of bug 44622

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Peter 'Rufus' Nelson]

In the CGI.pl file you get the following error when you run it:

defined(%hash) is deprecated at C:\mozilla\webtools\bugzilla\CGI.pl line 121 (#1)
    
    (D deprecated) defined() is not usually useful on hashes because it checks for an
    undefined scalar value.  If you want to see if the hash is empty,
    just use if (%hash) { # not empty } for example.  
    
	(Maybe you should just omit the defined()?)

Will attatch simple patch to fix.

Comment 1

[Peter 'Rufus' Nelson]

cvs diff CGI.pl (in directory C:\mozilla\webtools\bugzilla\)
Index: CGI.pl
===================================================================
RCS file: /cvsroot/mozilla/webtools/bugzilla/CGI.pl,v
retrieving revision 1.67
diff -r1.67 CGI.pl
121c121
<     if (defined %isnull) {
---
>     if (%isnull) {

Comment 2

[Dave Miller [:justdave]]

This is an artifact of upgrading to Perl 5.6.  There's more compatibility issues 
than just this, one... they're all covered in bug 44622.


*** This bug has been marked as a duplicate of 44622 ***

Comment 3

[Scott Brodmerkle]

Verified dupe.

Comment 4

[Dave Miller [:justdave]]

moving all closed Bugzilla bugs to the new Bugzilla product.
This batch is DUPLICATE/INVALID/WORKSFORME/WONTFIX
reassigning to default owner and QA in case of the bug being reopened.
Clearing milestones, since we really shouldn't have them on these types of
resolutions.  Sorry for the spam everyone...

Comment 5

[Markus Gerstel]

Verification got lost