478267 - [FIX]Any time we reflow an nsObjectFrame we assert

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

FinishAndStoreOverflow asserts that the overflow area contains the frame bounds.  The right fix for bug 475723 was to add the call to FinishAndStoreOverflow, not to replace the setting of the overflow area with it.

I guess we need this fixed on the 1.9.1 branch too, right?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 362066 [details] [diff] [review]
Fix

Oops, that was stupid of me.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yes, we should take this on 1.9.1.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/3eb478b0610e

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 362066 [details] [diff] [review]
Fix

Clearing approval request given blocking1.9.1+.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a6cec263daeb

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Backed out of 1.9.1 since we're backing out bug 475723, which this fixes a regression of. This is still fixed on 1.9.1 because of that backout.