478321 - infinite recursion crash with line-height: 1rem on root element

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, which crashes in current trunk build.
I seem to get different stacks.

http://crash-stats.mozilla.com/report/index/9ef0fb13-abcb-49c5-a5b6-089ed2090212?p=1
0  	xul.dll  	nsCSSCompressedDataBlock::MapRuleInfoInto  	 layout/style/nsCSSDataBlock.cpp:180
1 	xul.dll 	CSSStyleRuleImpl::MapRuleInfoInto 	layout/style/nsCSSStyleRule.cpp:1437
2 	xul.dll 	nsRuleNode::WalkRuleTree 	layout/style/nsRuleNode.cpp:1731
3 	xul.dll 	nsRuleNode::GetStyleFont 	layout/style/nsStyleStructList.h:73
4 	xul.dll 	CalcLengthWith 	layout/style/nsRuleNode.cpp:202
5 	xul.dll 	SetCoord 	layout/style/nsRuleNode.cpp:343
6 	xul.dll 	nsRuleNode::ComputeTextData 	layout/style/nsRuleNode.cpp:3062
7 	xul.dll 	nsRuleNode::WalkRuleTree 	layout/style/nsStyleStructList.h:89
8 	xul.dll 	nsRuleNode::GetStyleText 	layout/style/nsStyleStructList.h:89
9 	xul.dll 	nsStyleContext::GetStyleText 	layout/style/nsStyleStructList.h:89
10 		@0x2d83af7 	

http://crash-stats.mozilla.com/report/index/818a8198-33c7-4b6b-9454-405742090212?p=1
0  	xul.dll  	SelectorMatches  	 layout/style/nsCSSRuleProcessor.cpp:1213
1 	xul.dll 	ContentEnumFunc 	layout/style/nsCSSRuleProcessor.cpp:1892
2 	xul.dll 	RuleHash::EnumerateAllRules 	layout/style/nsCSSRuleProcessor.cpp:629
3 	xul.dll 	WrappedNativeProtoMarker 	
4 		@0x231f49f 	

http://crash-stats.mozilla.com/report/index/b0e3b89f-0b82-481b-a3db-87bf22090212?p=1
0  	xul.dll  	nsStyleUtil::IsLink  	 layout/style/nsStyleUtil.cpp:501
1 	xul.dll 	xul.dll@0x35bbac

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is a stack overflow; probably it's different stacks because something causes slight variation in the initial stack depth or the size of each recursive step.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is a stack overflow; probably it's different stacks because something causes slight variation in the initial stack depth or the size of each recursive step.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

This fixes it, although I'd like to think about it a little more and write some correctness mochitests.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Well, I don't really remember what it was I wanted to think about or test, but I wrote a few mochitests.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/2fa18f53503b

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Mass change: adding fixed1.9.2 keyword

(This bug was identified as a mozilla1.9.2 blocker which was fixed before the mozilla-1.9.2 repository was branched (August 13th, 2009) as per this query: http://is.gd/2ydcb - if this bug is not actually fixed on mozilla1.9.2, please remove the keyword. Apologies for the bugspam)