478339 - create uniqueID from memory address of accessible

Status: RESOLVED WORKSFORME

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

nsIAccessNode::uniqueID is formed from memory address of DOM element this accessible is created for. Since some accessibles shares the same DOM node (like treeitems accessible for xul:tree) then uniqueID is not unique. I guess we should for uniqueID from memory address of this accessible.

Comment 1

[alexander :surkov (:asurkov)]

I misread the code, now I see uniqueID should be unique for those accessibles that shares the same DOM node. I think we can simplify the code at this point and make uniqueID to be created from memory address of the accessible.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Aren't there still some handy keys based on things like row/col etc? Sorry this is a fly-by comment... based on some vague memories from tbird's email list.

Comment 3

[alexander :surkov (:asurkov)]

(In reply to comment #2)
> Aren't there still some handy keys based on things like row/col etc? Sorry this
> is a fly-by comment... based on some vague memories from tbird's email list.

David, sorry I don't follow you. Could you explain in details?

Comment 4

[alexander :surkov (:asurkov)]

Note, we can't easy turn to accessible address usage as a key because nsAccessibilityService::GetAccessible() check the document cache by DOM node as unique ID of the accessible.

Comment 5

[alexander :surkov (:asurkov)]

it was fixed at some point