478377 - Support specifying direction for :-moz-tree-cell pseudo class through CSS

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[(no longer active)]

Currently, if a tree body frame is RTL, it shows all its cells in RTL (the same goes for LTR).  Occasionally we need RTL data displayed in LTR trees (and vice versa).  I have a patch ready to add support for the CSS direction rule to the tree cells, which I will attach here together with a number of reftests.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Patch with reftest.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+      if (aDirection == NS_STYLE_DIRECTION_INHERIT)
+        aDirection = aFrame->GetStyleVisibility()->mDirection;

{} around the statement

+  if (!((isRTL && aTextRTL) || (!isRTL && !aTextRTL)))

Can't this just be "isRTL != aTextRTL"?

Comment 3

[(no longer active)]

Attachment: Patch (v1.1)

Addressed comments

Comment 4

[(no longer active)]

Attachment: Patch (v1.1)

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+  if (isRTL != aTextRTL) {
+    direction = aTextRTL ? NS_STYLE_DIRECTION_RTL :
+                           NS_STYLE_DIRECTION_LTR;
+  }

Actually, why can't this be unconditional?

Comment 6

[(no longer active)]

(In reply to comment #5)
> +  if (isRTL != aTextRTL) {
> +    direction = aTextRTL ? NS_STYLE_DIRECTION_RTL :
> +                           NS_STYLE_DIRECTION_LTR;
> +  }
> 
> Actually, why can't this be unconditional?

Hmmm, I think it can, because if direction is not set here, then nsLayoutUtils::DrawString will obtain the frame direction on its own, which is the same thing as |isRTL|.

Comment 7

[(no longer active)]

Attachment: Patch (v1.2)

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/247c0b3ec1aa

Comment 9

[(no longer active)]

Comment on attachment 362372 [details] [diff] [review]
Patch (v1.2)

This patch comes with a test, and is needed for bugs 477902 and 478430 for 1.9.1.  Requesting approval.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 362372 [details] [diff] [review]
Patch (v1.2)

a1.9.1=dbaron

Comment 11

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/6b1c58c16f5d

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with reftests on OS X and Windows:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090301 Minefield/3.2a1pre ID:20090301020403

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090301 Shiretoko/3.1b3pre ID:20090301020400