478414 - [SeaMonkey, MacOSX] "test_bug441782.html | Test timed out" now

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Serge Gautherie (:sgautherie)]

Bug 467672 comment 29 checkins fail on MacOSX SeaMonkey.

{
[...]
*** 42170 INFO TEST-PASS | /tests/layout/base/tests/test_bug441782.html | Rendering of reftest bug467672-5 is different with bidi.numeral == 3
*** 42171 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/base/tests/test_bug441782.html | Test timed out.
}

On
http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey&maxdate=1234493009
Regression timeframe:
http://hg.mozilla.org/releases/mozilla-1.9.1/pushloghtml?startdate=2009-02-12+10%3A53%3A50&enddate=2009-02-12+14%3A28%3A43

Comment 1

[(no longer active)]

Serge: do you have access to a Mac?  Can you reproduce this locally?  If yes, I'd like to attach a patch which catches any exceptions to see what's failing here.

Comment 2

[Serge Gautherie (:sgautherie)]

No, I have my local Windows 2000 only.

Comment 3

[(no longer active)]

Roc: do you have access to a Mac (and time to do the testing) or know someone who does?

Comment 4

[Robert Kaiser]

As a note, this unit test box is running Tiger, while I think all Firefox boxes are Leopard.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Jonathan might be able to help

Comment 6

[Jonathan Kew [:jfkthame]]

I'll take a look; currently pulling the source so I can start a SeaMonkey build. I don't have a Mac running Tiger, though, if that turns out to be a significant factor.

Comment 7

[Jonathan Kew [:jfkthame]]

This test runs ok for me on 10.5 (Leopard) using a 1.9.1 trunk build. I don't have access to Tiger for comparison here.

Is it simply timing out because it takes too long to complete? test_bug441782.html has a lot of sub-tests and runs pretty slowly; I just timed it at slightly over 1 minute on my laptop. What's the timeout used when running the unit tests? (IIRC I've seen 30 seconds mentioned somewhere, in which case a timeout would be quite likely on anything except a pretty fast Mac.) Maybe Ehsan could simply split it into a collection of separate files.

Comment 8

[(no longer active)]

Attachment: Split the tests

I think Jonathan's suggestion to split the test is worthwhile, here is the patch.  It doesn't include any changes to the test code, it just splits it to multiple files.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Even if it doesn't fix the problem, it will help narrow it down.

Comment 10

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/b6debd8f3a0d
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ab8f309ba4ab

I won't mark it as fixed now in order to wait and see the tests passing.

Comment 11

[(no longer active)]

The SeaMonkey test finally passed: <http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1234775152.1234782319.28786.gz>, so it seems like it was indeed a test taking too long to complete.  -> FIXED.  Thanks for the suggestion, Jonathan.

Comment 12

[Robert Kaiser]

And thanks for doing that fix, Ehsan.

Comment 13

[(no longer active)]

(In reply to comment #12)
> And thanks for doing that fix, Ehsan.

Sure thing.  Sorry for turning your tree orange in the first place.  :-)

Comment 14

[Serge Gautherie (:sgautherie)]

verified1.9.1, as box turned green.

Comment 15

[Boris Zbarsky [:bzbarsky]]

I suspect, for what it's worth, that the slowness was a combination of using slow canvas compare and reflowing the big mochitest document a whole bunch of times during these tests...