Closed
Bug 478536
Opened 16 years ago
Closed 16 years ago
Crash by removing a scroll target in MozMouseScrollFailed event handler
Categories
(Core :: DOM: UI Events & Focus Handling, defect)
Core
DOM: UI Events & Focus Handling
Tracking
()
RESOLVED
FIXED
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Keywords: crash, regression)
Attachments
(2 files, 1 obsolete file)
|
826 bytes,
text/html
|
Details | |
|
10.11 KB,
patch
|
Details | Diff | Splinter Review |
this is a regression of bug 442774.
At bug 442774, I added MozMouseScrollFailed event for automated testing, but the patch didn't check whether the target frame alive or not.
Steps for reproduce:
1. Open the attached testcase.
2. Scroll down the view to bottom by mouse wheel.
3. Scroll up the view to top by mouse wheel.
4. Scroll up the view to top again.
I'll post a patch.
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #362385 -
Flags: superreview?(roc)
Attachment #362385 -
Flags: review?(roc)
Comment on attachment 362385 [details] [diff] [review]
Patch v1.0
+ // By the event handler, the target frame might be destroyed. Then,
+ // we should not keep to handle this scroll event.
// In the event handler, the target frame might be destroyed. Then,
// we should not keep handling this scroll event.
Attachment #362385 -
Flags: superreview?(roc)
Attachment #362385 -
Flags: superreview+
Attachment #362385 -
Flags: review?(roc)
Attachment #362385 -
Flags: review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
Attachment #362385 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•16 years ago
|
||
pushed to trunk.
http://hg.mozilla.org/mozilla-central/rev/cc31eaf33c78
|
||
Updated•6 years ago
|
Component: Event Handling → User events and focus handling
You need to log in
before you can comment on or make changes to this bug.
Description
•