Closed Bug 47856 Opened 24 years ago Closed 24 years ago

No session history in Go menu and back/forward dropdown in Classic or Modern

Categories

(Core :: DOM: Navigation, defect, P3)

Product:
Core
Component:
DOM: Navigation
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: mozilla, Assigned: radha)

References

Details

(Keywords: regression)

Attachments

(1 file)

[patch] restore session history in go menu and back/forward dropdown
4.15 KB, patch
Details | Diff | Splinter Review 
2000080621

Browse to a few URL's. Press little down arrow on back button in either skin -- 
no drop down. Same with Forward button.

Not sure if history is broken somehow, or if it's just a chrome issue. I put the 
component as history since it's unlikely that both packages have the same chrome 
bug.
2000080620  --  Win98

I see the same problem.  Button history dropdown lists are not there.
I think danm removed a little of this code yesterday to try and fix a crasher.
Can it be put back in?
Keywords: regression
Yes, danm removed some code the back/forward button history and Go menu depend 
on.

I'm putting the finishing touch on a fix for this.
*** Bug 47904 has been marked as a duplicate of this bug. ***
er...yeah...this was known about last night.  Ben was supposed to checkin the 
patch for it since I'm away...
This also affected the browsing history in the Go menu btw...

Attaching a patch which fixes this.
Anyone wanna review?
Keywords: patch, review
Updating summary, setting to All All since this is XP.
OS: Windows 2000 → All
Hardware: PC → All
Summary: No drop down for Back/Forward in Classic or Modern → No session history in Go menu and back/forward dropdown in Classic or Modern
Blocks: 47490
*** Bug 48260 has been marked as a duplicate of this bug. ***
putting on dogfood radar. let's get this fixed soon, patch(es) exist.
Keywords: dogfood
radha checked my patch in, marking fixed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
*** Bug 48378 has been marked as a duplicate of this bug. ***
*** Bug 48383 has been marked as a duplicate of this bug. ***
*** Bug 48365 has been marked as a duplicate of this bug. ***
It is now over two weeks later, and this bug is still in the dailiy builds.
(2000082404).
actually, i haven't seen this in quite a while now. VERIFIED Fixed with the following smattering of builds (just to be reallly sure)

2000082308 Win98
2000082508 Linux RedHat 6.1
2000082108 MacOS 8.5.1
Status: RESOLVED → VERIFIED
My mistake. When I unzip the dailies on my machine, I only clean out the EXE and
DLL files. Apparently some other file in the directory was not being
over-written from the new daily build, and was preserving the broken behaviour.
After cleaning my installation more thoroughly, it is working properly.
Mass removing self from CC list.
Now I feel sumb because I have to add back. Sorry for the spam.
Component: History: Session → Document Navigation
QA Contact: claudius → docshell
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: