Closed Bug 478614 Opened 13 years ago Closed 13 years ago

vertical table margins not correctly applied if captions are present

Categories

(Core :: Layout: Tables, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bernd_mozilla, Assigned: bernd_mozilla)

References

Details

(Keywords: testcase)

Attachments

(2 files, 2 obsolete files)

Attached file testcase
this is a CSS2.1 issue
and the top margins of the table and the caption should collapse.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → bernd_mozilla
Status: NEW → ASSIGNED
Attached patch rev. patch (obsolete) — Splinter Review
Attachment #362464 - Attachment is obsolete: true
Attachment #362485 - Flags: superreview?(dbaron)
Attachment #362485 - Flags: review?(dbaron)
Hi Bernd, I came across this bug while working on bug 477462.

(In reply to comment #1)
> and the top margins of the table and the caption should collapse.

That's what the current CR says, but you don't take the Errata into account (boy, I'm happy the WG decided to publish a new CR soon..).

According to the errata, the anonymous block that includes the table and its caption is now a block formatting context. Another correction says that the outer vertical margins of a block formatting contexts do never collapse with margins of their in-flow children.

So caption margins should never collapse with table margins. This is possibly related to Bug 297676 which is based on an older version of the spec.
Comment on attachment 362485 [details] [diff] [review]
rev. patch

http://www.w3.org/Style/css2-updates/CR-CSS21-20070719-errata.html

man, do I love changing specs!
Attachment #362485 - Flags: superreview?(dbaron)
Attachment #362485 - Flags: review?(dbaron)
Attachment #362485 - Attachment is obsolete: true
Attachment #365511 - Flags: superreview?
Attachment #365511 - Flags: review?
Attachment #365511 - Flags: superreview?(dbaron)
Attachment #365511 - Flags: superreview?
Attachment #365511 - Flags: review?(dbaron)
Attachment #365511 - Flags: review?
Robert do you have time to review this? Its a IE8, webkit, opera parity bug. MS has a test case that demonstrates our wrong behavior.
Attachment #365511 - Flags: superreview?(dbaron)
Attachment #365511 - Flags: superreview+
Attachment #365511 - Flags: review?(dbaron)
Attachment #365511 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/b4b7eb4407c3
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Depends on: 501870
Duplicate of this bug: 563950
You need to log in before you can comment on or make changes to this bug.