478614 - vertical table margins not correctly applied if captions are present

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Bernd]

Attachment: testcase

this is a CSS2.1 issue

Comment 1

[Bernd]

and the top margins of the table and the caption should collapse.

Comment 2

[Bernd]

Attachment: patch

Comment 3

[Bernd]

Attachment: rev. patch

Comment 4

[Daniel.S]

Hi Bernd, I came across this bug while working on bug 477462.

(In reply to comment #1)
> and the top margins of the table and the caption should collapse.

That's what the current CR says, but you don't take the Errata into account (boy, I'm happy the WG decided to publish a new CR soon..).

According to the errata, the anonymous block that includes the table and its caption is now a block formatting context. Another correction says that the outer vertical margins of a block formatting contexts do never collapse with margins of their in-flow children.

So caption margins should never collapse with table margins. This is possibly related to Bug 297676 which is based on an older version of the spec.

Comment 5

[Bernd]

Comment on attachment 362485 [details] [diff] [review]
rev. patch

http://www.w3.org/Style/css2-updates/CR-CSS21-20070719-errata.html

man, do I love changing specs!

Comment 6

[Bernd]

Attachment: patch to incorporate the errata

Comment 7

[Bernd]

Robert do you have time to review this? Its a IE8, webkit, opera parity bug. MS has a test case that demonstrates our wrong behavior.

Comment 8

[Bernd]

http://hg.mozilla.org/mozilla-central/rev/b4b7eb4407c3