478618 - Cannot build by VS2005 without VistaSDK (Cannot open include file: 'msctf.h': No such file or directory)

Status: RESOLVED INVALID

(Core :: Widget: Win32, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

VS2005 doesn't have msctf.h, it's included in Vista SDK. Therefore, we need to install Vista SDK for building by VS2005. However, it changes our build requirements. I'm not sure it should be so.

The header file is needed by TSF support. If we make a new build option, e.g., "--disable-tsf-support", we can keep the build requirements.

Note that we should disable TSF support by "--disable-vista-sdk-requirements", maybe. Because I couldn't build Fx by VS2005+Vista SDK without the option.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We should fix things so that people can get a working build without changing their .mozconfigs or installing a new SDK.

Comment 2

[(not currently active) Ted Mielczarek]

roc: We already require the Vista SDK. --disable-vista-sdk-requirements should be fixed to cover this case as well. Our policy is not to silently disable code that you can't build, but to make configure provide useful error messages telling you what you're missing and how to either install it, or disable the code that won't build.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

OK then, so here we need to disable TSF if --disable-vista-sdk-requirements is set.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #0)
> Note that we should disable TSF support by "--disable-vista-sdk-requirements",
> maybe. Because I couldn't build Fx by VS2005+Vista SDK without the option.

Oops, I meant we should *not* disable TSF support by "--disable-vista-sdk-requirements".

I installed Vista SDK to my WinXP with VS2005. But I could not build Fx without "--disable-vista-sdk-requirements". But I can build TSF support enabled build. Therefore, if we disable the TSF support by the option, and we cannot enable only TSF support with another option, I cannot develop on XP expecting to upgrade the VS version.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Is this a regression? Did we add TSF support recently?

Either way, this doesn't block final release. As Ted mentions, we already require the Vista SDK, it's available for free as part of the free toolchain, etc (see https://developer.mozilla.org/en/Windows_Build_Prerequisites)

Comment 6

[(not currently active) Ted Mielczarek]

I'd like the 1.9.1 branch to continue to be buildable without the Vista SDK, but I think we could take that patch even after the release of 3.1, since it would be very low-impact, not changing the actual code that's built in the official builds.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

TSF isn't in the 1.9.1 branch so this is not a problem there.

Comment 8

[Serge Gautherie (:sgautherie)]

Bug 509179 duplicate, eventually? (Or what is the current status?)

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

VS2005 isn't supported anymore.