trees should support three finger swipe up/down on Mac OS X

VERIFIED FIXED in mozilla1.9.2a1

Status

()

Product:
Toolkit
Component:
XUL Widgets
Status:
VERIFIED FIXED
Reported:
10 years ago
Modified:
10 years ago

People

(Reporter: Mardak, Assigned: Mardak)

Tracking

(Blocks: 1 bug)

Version:
Trunk
Target:
mozilla1.9.2a1
Platform:
All
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

v1
1.16 KB, patch
enndeakin
: review+
beltzner
: approval1.9.1-
Details | Diff | Splinter Review
(Assignee)

Description

•
10 years ago 
Swipe up/down could scroll to the top/bottom of trees.
(Assignee)

Comment 1

•
10 years ago 
Created attachment 362493 [details] [diff] [review]
v1

Generalize to tree widgets..
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #362493 - Flags: review?(roc)

Comment 2

•
10 years ago 
I'm not the right reviewer for toolkit.
 (Assignee)

Updated

•
10 years ago
Attachment #362493 - Flags: review?(roc) → review?(gavin.sharp)
 (Assignee)

Updated

•
10 years ago
Attachment #362493 - Flags: review?(gavin.sharp) → review?(enndeakin)

Updated

•
10 years ago
Attachment #362493 - Flags: review?(enndeakin) → review+
 (Assignee)

Comment 3

•
10 years ago 
http://hg.mozilla.org/mozilla-central/rev/46424e50827c
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1

Comment 4

•
10 years ago 
Sorry, but this doesn't work at all with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090221 Minefield/3.2a1pre Ubiquity/0.1.5 ID:20090221020633

Trees support swipe up/down like the Library one but do we need an extra handler for the about:config window?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
 (Assignee)

Updated

•
10 years ago
Depends on: 479662
 (Assignee)

Comment 5

•
10 years ago 
Odd. I distinctively remember this working on about:config. But it totally makes sense why about:config doesn't work.. it's inside the browser element, and we stop propagation before it gets to the about:config document.

Switching this to just trees and filed bug 479662 about adjusting what can get gestures.
Blocks: 479662
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago → 10 years ago
No longer depends on: 479662
Resolution: --- → FIXED
Summary: about:config should support three finger swipe up/down on Mac OS X → trees should support three finger swipe up/down on Mac OS X

Comment 6

•
10 years ago 
Alright. That looks great in the Library. Verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090221 Minefield/3.2a1pre ID:20090221020633

Is this patch ready for 1.9.1?
Status: RESOLVED → VERIFIED
Attachment #362493 - Flags: approval1.9.1?
Attachment #362493 - Flags: approval1.9.1? → approval1.9.1-

Comment 7

•
10 years ago 
Comment on attachment 362493 [details] [diff] [review]
v1

Needs tests, please renominate once you have 'em.
You need to log in before you can comment on or make changes to this bug.