Closed Bug 478673 Opened 15 years ago Closed 15 years ago

tinderbox logs from buildbot slaves should all start by saying which slave is building

Categories

(Release Engineering :: General, defect, P2)

Product:
Release Engineering
Component:
General
Platform:
x86
All
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: nthomas, Assigned: nthomas)

Details

Attachments

(1 file)

OOP FTW
1.74 KB, patch
bhearsum
: review+
nthomas
: checked-in+
Details | Diff | Splinter Review
Attached patch OOP FTW — — Splinter Review 
Right now the build, leak, and unit test boxes say (eg)
  Building on: moz2-win32-slave13
in the log available via tinderbox, but its buried after four other cleanup steps (and a bunch of unnecessary env var listings). l10n, mobile, and release builds don't print anything at all.

This patch moves the slavename echo to the MozillaBuildFactory, which is a parent class for all those builds now. Tested on staging for all but mobile, but should work just fine.
Attachment #362510 - Flags: review?(bhearsum)
Priority: -- → P2
Summary: buildbot logs should all start by saying which slave is building → tinderbox logs from buildbot slaves should all start by saying which slave is building
Comment on attachment 362510 [details] [diff] [review]
OOP FTW

oop ftw indeed.
Attachment #362510 - Flags: review?(bhearsum) → review+
Comment on attachment 362510 [details] [diff] [review]
OOP FTW

Pushed to repo, will get picked up on next reconfig.
Attachment #362510 - Flags: checked‑in+ checked‑in+
Reconfig'ed for this today.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Verified on linux/mac/windows build/leak/unit/l10n for mozilla-central. Doesn't happen on Fx3.0 or 3.1 l10n because those are different systems.
Status: RESOLVED → VERIFIED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: