478685 - Using "Remove" to delete a revision does not remove article from Waiting for review category

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[E. Cooper [:ecooper]]

Steps to reproduce:

1. Edit a staging article that's currently not in the "Waiting for Review" cateogry
2. Use "remove" from the toolbox to delete the latest revision of the staging article
3. Revisit the staging article

If the staging article is the same as its KB counterpart, it should be removed from the Waiting for Review category. If it's different, it should be placed or stay in the Waiting for Review category.

Comment 1

[E. Cooper [:ecooper]]

This fix for checking staging articles against kb articles is in r22305/r22306.

This can be verified once staging reflects changes to trunk again.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

http://viewvc.svn.mozilla.org/vc/projects/sumo/trunk/webroot/tiki-removepage.php?r1=19580&r2=22305&pathrev=22305 references bug 410028, rather than this bug.

Comment 3

[E. Cooper [:ecooper]]

Corrected and clarified in r22456/r22457.

A recent stomach bug halted any productivity on my part. Thanks a million for reminding me, Stephen.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

When looking at this, I discovered that, while https://support-stage.mozilla.org/tiki-editpage.php?locale=en-US&page=fdsfdsa tells me I'm, "editing the approved copy of this page.
For guidelines, please read our Best Practices for Support Documents page and Manual of Style.
Are you sure you do not want to edit the staging copy instead?", https://support-stage.mozilla.org/en-US/kb/fdsfdsa is a 404.

Why is that?

Comment 5

[E. Cooper [:ecooper]]

The conditional in the smarty template that displays the "You are editing [...]" spiel is decided on by a conditional in webroot/tiki-editpage.php:1098.

Basically, if it's a new page it looks like it's being seen as an KB page. This should only happen for the first edit of new pages, though.

Comment 6

[E. Cooper [:ecooper]]

I now realize my second sentence doesn't make sense outside of my head. 

I essentially meant that the template doesn't check if the page actually exists or not when it displays that chunk, it just displays information based on whether or not it needs/is a staging page.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; Chris and I tested this and it works, but redirects the user to the Contributor Home Page after the removal.