478707 - SeaMonkey sessionstore saves, but doesn't restore closed tabs list.

Status: RESOLVED DUPLICATE of bug 530735

(SeaMonkey :: Session Restore, defect)

Description

[Misak Khachatryan]

Due to different way of Undo Close Tab, suite's sessionstore doesn't restore closed tabs list. One of the methods to fix this is to move move restoreTab method to sessionstore and maintain _closedTabs (like FF does) instead of savedBrowsers, but use Seamonkey way of undo close tab.

Comment 1

[Simon Bünzli]

Another method would be to serialize savedBrowsers.history when saving session state (or better when a tab is closed) and recreating both the <xul:browser> and its session history when restoring a session. You should even be able to use sss_serializeHistoryEntry and sss_deserializeHistoryEntry to do some of the lifting.

Comment 2

[Michael Kraft [:morac]]

Is this bug going to make it by the release of SeaMonkey 2.0?  If not the fix for bug 479448 should be checked in.

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

The comments in bug 530735 suggest that the patch that has just been checked in for that bug would fix this one, too. Is that right? I haven't tried it yet.

Comment 4

[Michael Kraft [:morac]]

A simple test would be to download the Session Manager add-on and then save a session with a bunch of closed tabs.  Close SeaMonkey and reopen it and then restore the session.  If the closed tabs from the save session are displayed in the closed tab list and can be re-opened then I'd say it's fixed.

I can check it myself, but since the fix was pushed today it won't be in a nightly build until tomorrow.

Comment 5

[Misak Khachatryan]

Yes, this bug is fixed now. I'm curious about resolution, maybe WORKSFORME.

Comment 6

[Jens Hatlak (:InvisibleSmiley)]

(In reply to comment #5)
> Yes, this bug is fixed now. I'm curious about resolution, maybe WORKSFORME.

WORKSFORME is for the case where a reported problem went away and the reason is not clear (i.e. it is unknown which change/patch/bug fixed it) or there was no problem at all in the first place. Here the problem did exist and it is known which bug fixed it so this a duplicate of that.

Comment 7

[Philip Chee]

I would say "FIXED by the fix in bug 530735" instead.

Comment 8

[Michael Kraft [:morac]]

Well I tested it and it's definitely NOT fixed in the SeaMonkey Trunk load, but since this has been duped to bug 530735, I'll comment there.

Comment 9

[Michael Kraft [:morac]]

Never mind, it looks like the fix for bug 530735 is not in the SeaMonkey 20100205 trunk load for whatever reason.  Not sure why that is considering it was checked in yesterday.  I'll try again later.