Closed Bug 478750 Opened 11 years ago Closed 8 years ago

closing last tab using _endRemoveTab in tabbrowser.xml is synchronous and performance intensive

Categories

(Firefox :: Tabbed Browser, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED WONTFIX

People

(Reporter: beltzner, Unassigned)

Details

(Keywords: perf, Whiteboard: [snappy])

Spun off from bug 476928 which itself was spawned from bug bug 473843 comment 10 and bug 473843 comment 11

Quoting from bug 473843:

> [it] seems to be that _endRemoveTab in tabbrowser.xml does some
> performance intensive scrolling (sync'd) when the last tab is removed

In bug 476928 Henrik suggests we "fix this in tabbbrowser" instead of using a suggested wallpaper fix (don't remove tabs starting from the end). I'm spinning this bug out because I'm

 - not sure we can fix this (as the scrolling behaviour is desired, I think)
 - entirely sure we don't want to block up fixing bug 476928

The purpose of this bug is to look at _endRemoveTab and see if there are ways to fix the synchronous performance issue that it contains.
Whiteboard: [tsnap]
(In reply to comment #0)
>  - not sure we can fix this (as the scrolling behaviour is desired, I think)

So do I. Making it asynchronous doesn't sound like it would make things snappier under normal circumstances (i.e. user closes a tab). And in not-so-normal circumstances, this can be optimized on the call side, as bug 476928 shows.

Unless there are better ideas how performance could be improved, I think this is wontfix.
(In reply to Dão Gottwald [:dao] from comment #1)
> 
> Unless there are better ideas how performance could be improved, I think
> this is wontfix.

time to close?
Whiteboard: [tsnap] → [snappy]
I think this is a wontfix.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Whiteboard: [snappy] → [snappy] (qa)
Whiteboard: [snappy] (qa) → [snappy]
You need to log in before you can comment on or make changes to this bug.