478771 - Bugzilla::Search should drop invalid bug statuses from the search criteria

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[David Lawrence [:dkl]]

Attachment: Patch to filter valid bug statuses in Bugzilla::Search (v1)

This was brought to our attention by someone using the XMLRPC api to search the bugs database here at Red Hat. Basically in the Bugzilla::Search code it simply checks to see if the number of statuses specified in the search criteria matches the total number of bug statuses and if the equal it assumes you want all bugs regardless of status. This user had an old status in his list and had the CLOSED state omitted (to find all open bugs) and the system thought they wanted all.

https://bugzilla.redhat.com/show_bug.cgi?id=485777

The attached patch filters out the invalid statuses and then does the number comparison against the legal statuses list.

Dave

Comment 1

[Max Kanat-Alexander]

Comment on attachment 362609 [details] [diff] [review]
Patch to filter valid bug statuses in Bugzilla::Search (v1)

>Index: Bugzilla/Search.pm
>+        else {
>+            $params->param('bug_status', @bug_statuses);
>+        }

  Did you mean to put valid_statuses there instead?

Comment 2

[David Lawrence [:dkl]]

Attachment: Patch to filter valid bug statuses in Bugzilla::Search (v2)

Thanks Max. Here is a new patch that should be correct and also works with latest trunk.

Comment 3

[Max Kanat-Alexander]

Comment on attachment 443276 [details] [diff] [review]
Patch to filter valid bug statuses in Bugzilla::Search (v2)

Looks good to me.

Comment 4

[Max Kanat-Alexander]

The Bugzilla UI or WebService can't trigger this, right? So there's no user-facing bug, so this is essentially an improvement for people who hack the URL or have custom WebServices, so it seems like it should go on HEAD, right?

Comment 5

[David Lawrence [:dkl]]

It can be triggered with the UI if some uses a bookmarked URL or saved search that still has the deleted status and therefore the same number of status values as the total number of valid statuses in Bugzilla (including CLOSED). This will fix those and the user can then resave their new search if desired. The WebService front end should not affected by this as it uses Bugzilla::WebService::Bug::search does not the same @bug_statuses == @legal_statuses type check and just takes the list of statuses that the client gives directly.

Comment 6

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/                                                                           modified Bugzilla/Search.pm
Committed revision 7152

Comment 7

[Max Kanat-Alexander]

Okay, so a backport to 3.6 sounds OK then.

Comment 8

[David Lawrence [:dkl]]

Attachment: Patch to filter valid bug statuses in Bugzilla::Search (3.6) (v2)

Here is the patch for 3.6 which is essentially the same as trunk. Let me know if I should go ahead and just r+ it from the prior review and check it in to the 3.6 branch.

Dave

Comment 9

[Max Kanat-Alexander]

Comment on attachment 444336 [details] [diff] [review]
Patch to filter valid bug statuses in Bugzilla::Search (3.6) (v2)

Looks good.

Comment 10

[David Lawrence [:dkl]]

Thanks Max.

Committing to: bzr+ssh://[e-mail]/bugzilla/3.6/
modified Bugzilla/Search.pm
Committed revision 7093.