478784 - autoscroll icon and tab preview panel are not transparent anymore

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090216 Minefield/3.2a1pre ID:20090216042918

repro:
open FF
press ctrl+tab

result:
the preview pane is not transparent anymore

repro 2:
open a page
middleclick to activate the autoscroll icon

result:
It's not transparent anymore

regressionwindow:
works in 20090215 nightly
fails in 20090216 nightly

Comment 1

[philippe (part-time)]

regression from bug 476557 or bug 475343 ?

Anyway, All/All as I see this on OS X.

Comment 2

[Dão Gottwald [:dao]]

Changing summary to mention the autoscroll icon first, as this is more relevant for 3.1.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Oh dear. Probably 476557

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Is this bug present on 1.9.1 yet, or has the patch that caused it not landed there yet?

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It hasn't landed yet.

Comment 7

[Zack Weinberg (:zwol)]

I can see the regression using the middle-click dingus, but ctrl-tab does not bring up any "preview pane" for me; please give more detailed instructions on how to see that.

Comment 8

[Peter van der Woude [:Peter6]]

(In reply to comment #7)
> I can see the regression using the middle-click dingus, but ctrl-tab does not
> bring up any "preview pane" for me; please give more detailed instructions on
> how to see that.

press on the "list all tabs" button on the extreme-right of the tab bar.

Comment 9

[Zack Weinberg (:zwol)]

got it, thanks.

Comment 10

[Zack Weinberg (:zwol)]

Attachment: patch

In PresShell::Paint, if inside a transparent widget, we must use complete transparency for the backstop color *even if* the view manager has a cached non-transparent background color to suggest.  This fixes both the tab preview and the middle-click-scroll wart.

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Too bad there's no real way to test this.

Comment 12

[Dão Gottwald [:dao]]

You could open a panel in a reftest, right? See e.g. attachment 356500 [details].

Comment 13

[Zack Weinberg (:zwol)]

(In reply to comment #12)
> You could open a panel in a reftest, right? See e.g. attachment 356500 [details].

Beyond my XUL-fu, I'm afraid.

Comment 14

[Dão Gottwald [:dao]]

You can just copy the XUL+JS from there and the CSS from the autoscroll icon :)
http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/winstripe/global/global.css#311

Comment 15

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yeah, but drawWindow applied to the panel content wouldn't have caught this bug, since drawWindow takes a different painting path that ignores the "fallback background color".

Comment 16

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed http://hg.mozilla.org/mozilla-central/rev/d9d4bf676f65

Comment 17

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090219 Minefield/3.2a1pre ID:20090219032045

verified on windows

Comment 18

[Zack Weinberg (:zwol)]

Attachment: rollup bundle for 1.9.1 branch

This Mercurial bundle contains the patches for all of these bugs:

https://bugzilla.mozilla.org/buglist.cgi?bugidtype=include&bug_id=469170%2C473398%2C474201%2C475548%2C476557%2C478784

rediffed for the 1.9.1 branch as of right now.

Comment 19

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 364156 [details]
rollup bundle for 1.9.1 branch

a191=beltzner

Comment 20

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/191401e9d02a