478810 - document role="textbox" fails assertion

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[David Bolter [:davidb] (NeedInfo me for attention)]

Spin off from bug 467387, failing test will be posted as part of patch/fix there.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

The problem is in in nsAccessible::GetState, when we do:
 nsCOMPtr<nsIContent> content(do_QueryInterface(mDOMNode))
 NS_ENSURE_STATE(content);

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

I chatted with bz, and we debugged this together. The mDOMNode is an nsHTMLDocument, which does not support nsIContent. Taking...

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: WIP

This fixes the bug. We basically need to be careful in nsAccessible with mDOMNode. Sometimes the concrete type will be nsHTMLDocument which does not support nsIContent -- see patch for details.

Please check for leaks... I'm doing QI

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: WIP tweaked

tweaked a test.

Comment 5

[alexander :surkov (:asurkov)]

Comment on attachment 363940 [details] [diff] [review]
WIP tweaked


>+    if (!content) {
>+      // mDOMNode is probably an nsHTMLDocument (perhaps from an iframe)
>+      nsCOMPtr<nsIDocument> document(do_QueryInterface(mDOMNode));
>+      if (document)
>+        content = document->GetRootContent();
>+    }

use nsCoreUtils::GetRoleContent instead, with this r=me

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch 1

Carrying forward Surkov's r+, thanks, Marco if you approve please push this fix.

Comment 7

[Marco Zehe (:MarcoZ)]

Comment on attachment 364103 [details] [diff] [review]
patch 1

This is great, thanks!

Comment 8

[Marco Zehe (:MarcoZ)]

Pushed on David's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/c7980dea1918

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 364103 [details] [diff] [review]
patch 1

a191=beltzner

Comment 10

[Marco Zehe (:MarcoZ)]

Pushed to mozilla-1.9.1 on David's behalf in changeset:
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ecba245024a0

Comment 11

[Marco Zehe (:MarcoZ)]

Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090422 Shiretoko/3.5b4pre (.NET CLR 3.5.30729)