478840 - markAsNotJunkMarksUnRead should only apply when the message is unjunked

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[Kent James (:rkent)]

In bug 208197, new behaviour was introduced that by default clears the read status of emails when they are marked as not junk. This is supporting a particular use case, where the message to be marked is falsely marked as junk, and is being moved to another folder.

But the code does not check for that condition. There are other use cases. In particular, I have been recommending to people that they need to train some messages as "Not Junk", else they will accumulate only Junk training and prevent the bayesian filter from operating correctly. The extension JunQuilla provides specific support for that with an "Uncertain" folder. Here, users are training as NotJunk emails that are already marked as NotJunk (but not trained) by the Bayesian spam filter. The message does not move, and in most cases has already been processed by the user. There is no need to clear the Read flag in such cases, and in fact it is very annoying when it does clear.

So now, by default, when a user decides to train an uncertain email as Good, that email is marked as Unread - even if it has not moved, and was not previously marked as Junk. This requires them to remark the email as Read, which is double the work. Thus we are discouraging the training of Good emails, when the UI needs to do everything possible to encourage some of that training.

The marking can be turned off in a hidden preference, and that is what I will do in my extension for beta2. But then you lose the original purpose of the marking, which was to warn the user of new emails entering the inbox.

I think what it should do is to only reset the Read status in cases where the email is going to be moved to a different folder.

Comment 1

[Przemyslaw Bialik]

I think this is mistake in the checked in patch because original idea / patch was marking as unread (based on the pref) and unjunking only when it was being done in the junk folder.

Comment 2

[David :Bienvenu]

Neil asked me to do that, iirc - the auto marking as junk marks the message read, so we're basically undoing that. I don't care much one way or the other.

Comment 3

[Kent James (:rkent)]

(In reply to comment #2)
"the auto marking as junk marks the message read, so we're basically undoing that"

If that is the case, then you should only be changing unread for messages that are marked as junk - which is not how it is working currently.

It sounds like there is little controversy to this, so I'll do a patch for beta3 that changes this.

Comment 4

[David :Bienvenu]

oh, sorry, I didn't read your comment closely enough - yes, we should be checking the junk status there.

Comment 5

[Kent James (:rkent)]

Attachment: Only change unread on good for moves from junk folder [Checkin: Comment 8]

Comment 6

[Przemyslaw Bialik]

(In reply to comment #2)
> iirc - the auto marking as junk marks the message read
from what I see it depends on the setting in options
mail.spam.markAsReadOnSpam;false=default

for manual marking as junk:
mailnews.ui.junk.manualMarkAsJunkMarksRead;true=default

Comment 7

[David :Bienvenu]

Comment on attachment 363072 [details] [diff] [review]
Only change unread on good for moves from junk folder
[Checkin: Comment 8]

I had intended that you check the msg flags, not the folder flags, but it's not important. Turns out what Neil had asked for before was to clear the deleted flag in the case of the imap delete model, not the read flag...

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 363072 [details] [diff] [review]
Only change unread on good for moves from junk folder
[Checkin: Comment 8]


http://hg.mozilla.org/comm-central/rev/43040865fa92