478862 - After Bugfix 347185 the keys Backspace and Tab no longer work as expected in a flash application

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P2)

Description

[gerd.flender]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1b3pre) Gecko/20090216 Firefox/3.1b3pre

The fix for bug 347185 gives a new problem:

With the actual nightly (firefox-3.1b3pre.de.win32.installer.exe from 2009-02-16) I have the problem that the special keys TAB and
BACKSPACE no longer work in a flash application as expected.

TAB leads away from the flash application to the browser URL window and
BACKSPACE goes back one page in the browser (like you hit the back button).

You can verify that at the above mentioned page:
http://g.ho.st/vc.html
With former versions that worked fine.

Reproducible: Always

Steps to Reproduce:
1. open the above mentioned URL http://g.ho.st/vc.html
2. enter cursor in ID or password field
3. enter something
4. press BACKSPACE OR TAB
Actual Results:  
TAB leads away from the flash application to the browser URL window and
BACKSPACE goes back one page in the browser (like you hit the back button).

Expected Results:  
TAB should focus the next field in the flash application
BACKSPACE should only delete the last entered character

See also Bug 347185

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I'm not sure this is our bug. Because:
1. I cannot reproduce the backspace issue.
2. I cannot reproduce this bug on other site.

Comment 2

[gerd.flender]

Hmm, maybe it's a problem with Openlaszlo.
It worked before the bugfix 347185.
Another requirement seems to be wmode="transparent" as it was for bug 347185

Do you see the tab problem on the above mentioned site?
The backspace issue occurs of course only if there is a page to which you can go back.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0

ok, we should stop propagation of keypress events for compatibility.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

We should fix this regression.

Comment 5

[Masatoshi Kimura [:emk]]

Plug-in may want to leave focus when TAB key is pressed (see bug 93149.)
Probably we will need a new NPAPI variable to determine whether we can trust a return value from NPP_HandleEvent().

Comment 6

[dan050782]

I have seen in the past month or so in the branch nightlies, that the left and right arrow keys skip over 2 characters instead of one in some flash objects 

Also the home and end keys move to the top and bottom of the page, as well as the beginning and end of the line of text in the flash object.  When really the latter behavior should only be happening when the flash object has focus.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Kimura-san, you're right for the accessibility. But it should not be the scope of this bug and bug 272847. Because we should fix only "IME accessibility problem of windowless mode" and "some non-US keyboard layout accessibility problem of windowless mode".

And also we need to fix most regressions on the branch by low risk patch.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

landed to trunk.
http://hg.mozilla.org/mozilla-central/rev/35d78a340566

I'll land to 1.9.1 branch several days later.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

landed to 191branch too.
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4ad8a3b961e1

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090224 Minefield/3.2a1pre

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090301 Shiretoko/3.1b3pre ID:20090301033810

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Oh, could we somehow get this tested with the test plugin? Josh, would this be possible?

Comment 12

[Josh Aas]

I'm not sure if it is possible to test, Masayuki would know. You'd probably have to generate a native key event from the test plugin, doesn't seem like it would be too hard.

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

How to write the plug-in tests? I don't know the "test plugin".

Comment 14

[Josh Aas]

mozilla/modules/plugin/test/