The default bug view has changed. See this FAQ.

Need a way from chrome to know when error pages load

RESOLVED FIXED in mozilla15

Status

()

Core
Document Navigation
RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: johnath, Assigned: O. Atsushi (Torisugari))

Tracking

Trunk
mozilla15
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

8 years ago
Whether this means firing DOMContentLoaded on error pages, or inventing some new event that is error-page-specific, it would be extremely helpful to be able to listen for error page loads.

It would help with bugs like bug 425001, but also with things like bug 428948

Updated

8 years ago
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Updated

5 years ago
Blocks: 623155
(Assignee)

Updated

5 years ago
Depends on: 673752
(Assignee)

Comment 1

5 years ago
Created attachment 618640 [details] [diff] [review]
proposal v1

I'm not yet sure this is the right fix for bug 623155, but, in general, it would be useful.

>+   *   |aWebProgress| does NOT set this flag when it did not try to load a new
>+   *   contents. In this case, it should set LOCATION_CHANGE_SAME_DOCUMENT.
If this behavior is not allowed, probably docshell needs another member variable to store this flag.
(Assignee)

Updated

5 years ago
Attachment #618640 - Flags: review?(bugs)

Comment 2

5 years ago
Comment on attachment 618640 [details] [diff] [review]
proposal v1

This needs tests.
Attachment #618640 - Flags: review?(bugs) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 619197 [details] [diff] [review]
Test

Test, appending to bug 311007's.

BTW, during writing the test, I found that my comment for the idl 

> Both |aURI| and |aRequest| may be null.

is a lie. Always aURI is not null. However it can be converted from null to <about:blank> in a very edge case, though I don't know how to reproduce.
Attachment #619197 - Flags: review?(bugs)
(Assignee)

Updated

5 years ago
Attachment #618640 - Flags: superreview?(bzbarsky)
Comment on attachment 618640 [details] [diff] [review]
proposal v1

sr=me
Attachment #618640 - Flags: superreview?(bzbarsky) → superreview+
(Assignee)

Comment 5

5 years ago
Created attachment 619290 [details] [diff] [review]
proposal v1.1

Fixed IDL comments.
Attachment #618640 - Attachment is obsolete: true

Updated

5 years ago
Attachment #619197 - Flags: review?(bugs) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed

Updated

5 years ago
Assignee: nobody → torisugari
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f05a7ffcfb3
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8c356534c6a
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/4f05a7ffcfb3
https://hg.mozilla.org/mozilla-central/rev/d8c356534c6a

\o/
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Blocks: 752447
(Assignee)

Updated

5 years ago
No longer blocks: 623155
(Assignee)

Updated

5 years ago
Blocks: 623155
You need to log in before you can comment on or make changes to this bug.