object leak in pkix_List_MergeLists function

RESOLVED FIXED in 3.12.3

Status

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: alvolkov.bgs, Assigned: alvolkov.bgs)

Tracking

3.12.3
3.12.3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 362759 [details] [diff] [review]
pkix_list.c patch v1 - fix code that leaks object referenced by "item"

The leak has been detected by object leak testing tinderbox, but was not reported by the tinderbox website. The reason for that is a failure to upload a log file what is bigger than 50Mb. 
The memory leak checking tinderbox generates a big logs in case of memory leaks
if there is NSPR_LOG_MODULES variable is set to pkix:1 in the environment. 

Slavo will restart the tinderbox script on the machine without NSPR_LOG_MODULES variable. This will make the log to be within the allowed limits.

The code that was causing the leak is in pkix_List_MergeLists. The object referenced by (PKIX_PL_Object*)item was not de-referenced in case of an error.
Attachment #362759 - Flags: review?(nelson)
Comment on attachment 362759 [details] [diff] [review]
pkix_list.c patch v1 - fix code that leaks object referenced by "item"

r=nelson
Attachment #362759 - Flags: review?(nelson) → review+
Target Milestone: 3.12.1 → 3.12.3
(Assignee)

Comment 2

10 years ago
fix integrated
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.