Closed Bug 478931 Opened 12 years ago Closed 12 years ago

object leak in pkix_List_MergeLists function

Categories

(NSS :: Libraries, defect)

3.12.3
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
3.12.3

People

(Reporter: alvolkov.bgs, Assigned: alvolkov.bgs)

Details

Attachments

(1 file)

The leak has been detected by object leak testing tinderbox, but was not reported by the tinderbox website. The reason for that is a failure to upload a log file what is bigger than 50Mb. 
The memory leak checking tinderbox generates a big logs in case of memory leaks
if there is NSPR_LOG_MODULES variable is set to pkix:1 in the environment. 

Slavo will restart the tinderbox script on the machine without NSPR_LOG_MODULES variable. This will make the log to be within the allowed limits.

The code that was causing the leak is in pkix_List_MergeLists. The object referenced by (PKIX_PL_Object*)item was not de-referenced in case of an error.
Attachment #362759 - Flags: review?(nelson)
Comment on attachment 362759 [details] [diff] [review]
pkix_list.c patch v1 - fix code that leaks object referenced by "item"

r=nelson
Attachment #362759 - Flags: review?(nelson) → review+
Target Milestone: 3.12.1 → 3.12.3
fix integrated
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.