Last Comment Bug 478931 - object leak in pkix_List_MergeLists function
: object leak in pkix_List_MergeLists function
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: 3.12.3
: All All
: -- normal (vote)
: 3.12.3
Assigned To: Alexei Volkov
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-02-17 12:42 PST by Alexei Volkov
Modified: 2009-02-17 15:23 PST (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
pkix_list.c patch v1 - fix code that leaks object referenced by "item" (675 bytes, patch)
2009-02-17 12:42 PST, Alexei Volkov
nelson: review+
Details | Diff | Splinter Review

Description Alexei Volkov 2009-02-17 12:42:36 PST
Created attachment 362759 [details] [diff] [review]
pkix_list.c patch v1 - fix code that leaks object referenced by "item"

The leak has been detected by object leak testing tinderbox, but was not reported by the tinderbox website. The reason for that is a failure to upload a log file what is bigger than 50Mb. 
The memory leak checking tinderbox generates a big logs in case of memory leaks
if there is NSPR_LOG_MODULES variable is set to pkix:1 in the environment. 

Slavo will restart the tinderbox script on the machine without NSPR_LOG_MODULES variable. This will make the log to be within the allowed limits.

The code that was causing the leak is in pkix_List_MergeLists. The object referenced by (PKIX_PL_Object*)item was not de-referenced in case of an error.
Comment 1 Nelson Bolyard (seldom reads bugmail) 2009-02-17 13:05:45 PST
Comment on attachment 362759 [details] [diff] [review]
pkix_list.c patch v1 - fix code that leaks object referenced by "item"

r=nelson
Comment 2 Alexei Volkov 2009-02-17 15:23:26 PST
fix integrated

Note You need to log in before you can comment on or make changes to this bug.