The default bug view has changed. See this FAQ.

Allow Softoken's fork check to be disabled

RESOLVED FIXED in 3.12.3

Status

NSS
Libraries
P1
major
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Nelson Bolyard (seldom reads bugmail), Assigned: Nelson Bolyard (seldom reads bugmail))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: FIPS SUN_MUST_HAVE)

Attachments

(1 attachment)

Created attachment 362835 [details] [diff] [review]
patch v1 - untested

The fork checking that we introduced to Softken in NSS 3.12.3 has 
caused some old programs that dependend on the old behavior to stop 
working.  The developers of those programs desire that they be able to 
continue to operate as they have done for years.  They desire a way to 
disable Softoken's new fork checks.

The attached patch offers one proposed method for doing this. It adds 
another reserved string for the environment variable NSS_STRICT_NOFORK.
When C_Initialize detects that it is set to "DISABLED", C_Initialize 
will disable the fork checks.  

Before I ask for formal review of this patch, I'd like to know if it 
causes anyone great angst.
(Assignee)

Updated

8 years ago
Priority: -- → P1
Whiteboard: FIPS SUN_MUST_HAVE

Comment 1

8 years ago
I never understood why we wanted to add the fork check
to the softoken, so I have no comments for this bug.

Comment 2

8 years ago
Comment on attachment 362835 [details] [diff] [review]
patch v1 - untested

r+

rrelyea (once it's tested).
Attachment #362835 - Flags: review+
Christophe, 
Please prepare a test build with this patch and prepare to test DS5 with
that version of NSS and the environment variable 
NSS_STRICT_NOFORK=DISABLED

Comment 4

8 years ago
Nelson,

There is a typo in your patch at line 362  	

        if ( doForkCheck && !strcmp(doForkCheck, "DISBLED") ) { \

"DISBLED" should be "DISABLED"
I fixed the spelling of DISABLED and committed the patch.
Checking in pkcs11.c;   new revision: 1.161; previous revision: 1.160
Checking in softoken.h; new revision: 1.23; previous revision: 1.22
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.