Closed
Bug 479022
Opened 15 years ago
Closed 15 years ago
fast path nsCanvasRenderingContext2D::PutImageData() is wrong on BIG_ENDIAN machine
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)
References
Details
(Keywords: fixed1.9.1, regression)
Attachments
(1 file)
|
1.37 KB,
patch
|
vlad
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
it should be ARGB, not RGBA.
Introduced by Bug 451242.
Attachment #362867 -
Flags: review?(vladimir) → review+
|
||
Comment 2•15 years ago
|
||
Not blocking, once the patch has baked on trunk for a day please nominate it for approval and we'll take it.
Flags: wanted1.9.1+
Flags: blocking1.9.1?
Flags: blocking1.9.1-
Pushed: http://hg.mozilla.org/mozilla-central/rev/6529eed343b2
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Attachment #362867 -
Flags: approval1.9.1?
|
|
||
Updated•15 years ago
|
Attachment #362867 -
Flags: approval1.9.1? → approval1.9.1+
|
|
||
Comment 5•15 years ago
|
||
Comment on attachment 362867 [details] [diff] [review] patch a191=beltzner
Pushed to 1.9.1 http://hg.mozilla.org/releases/mozilla-1.9.1/rev/612da54b944e BTW: This bug is reproducible with Firefox 3.1 beta 3 on Mac OS X/ppc.
Keywords: fixed1.9.1
|
||
Comment 7•15 years ago
|
||
Why is not the fast premultiply macro used here? http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/public/gfxColor.h 126 #define GFX_DIVIDE_BY_255(v) \ 127 (((((unsigned)(v)) << 8) + ((unsigned)(v)) + 255) >> 16)
You need to log in
before you can comment on or make changes to this bug.
Description
•