Closed Bug 479022 Opened 16 years ago Closed 16 years ago

fast path nsCanvasRenderingContext2D::PutImageData() is wrong on BIG_ENDIAN machine

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
Sun
OpenSolaris
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

References

Details

(Keywords: fixed1.9.1, regression)

Attachments

(1 file)

patch
1.37 KB, patch
vlad
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review
it should be ARGB, not RGBA.
Attached patch patch — — Splinter Review
Introduced by Bug 451242.
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #362867 - Flags: review?(vladimir)
Severity: normal → critical
Flags: blocking1.9.1?
Keywords: regression
Not blocking, once the patch has baked on trunk for a day please nominate it for approval and we'll take it.
Flags: wanted1.9.1+
Flags: blocking1.9.1?
Flags: blocking1.9.1-
Pushed: http://hg.mozilla.org/mozilla-central/rev/6529eed343b2
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Attachment #362867 - Flags: approval1.9.1?
Mike, it has baked for a week.
Attachment #362867 - Flags: approval1.9.1? → approval1.9.1+
Pushed to 1.9.1 http://hg.mozilla.org/releases/mozilla-1.9.1/rev/612da54b944e BTW: This bug is reproducible with Firefox 3.1 beta 3 on Mac OS X/ppc.
Keywords: fixed1.9.1
Why is not the fast premultiply macro used here? http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/public/gfxColor.h 126 #define GFX_DIVIDE_BY_255(v) \ 127 (((((unsigned)(v)) << 8) + ((unsigned)(v)) + 255) >> 16)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: