479084 - JSScope should inherit from JSObjectMap, JSObject.map should be a JSScope and not just a JSObjectMap

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

We have C++, no need for C fake-inheritance.  It's also worth changing JSObject.map to be a JSScope at the same time, since that's really what it is per the OBJ_SCOPE macro (which really wouldn't have a need to exist with this change); I'd go a step further and rename the field as well since it's really a scope, but that's less important than reducing the need for casts.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

(In reply to comment #0)
> It's also worth changing
> JSObject.map to be a JSScope at the same time, since that's really what it is
> per the OBJ_SCOPE macro

Only if OBJ_IS_NATIVE(obj). Currently liveconnect is the only consumer I know of that uses this fact, but IMO this change isn't correct.

Comment 2

[Brendan Eich [:brendan]]

Not just liveconnect -- shavarrays!

Let's please not do this piecemeal. Noting dep, but it'll probably be patched all together. We need other object layout improvements.

/be

Comment 3

[Mike Shaver (:shaver emeritus)]

shavarrays aren't native, but do use a JSObjectMap nonetheless.  The plan was to use the refactored title stuff to make them threadsafety, but...hey, look at the time!

Comment 4

[Luke Wagner [:luke]]

bug 648647 zapped JSObjectMap