Closed
Bug 479150
Opened 15 years ago
Closed 15 years ago
[silme] wrong Blob detection in silme.io.file.write_object() causes crashes
Categories
(Mozilla Localizations :: Infrastructure, defect)
Mozilla Localizations
Infrastructure
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: adriank, Unassigned)
References
Details
Attachments
(1 file)
|
1.32 KB,
patch
|
zbraniecki
:
review+
|
Details | Diff | Splinter Review |
This if statement: http://hg.mozilla.org/users/zbraniecki_mozilla.com/silme/file/4b98536173ad/lib/silme/io/file.py#l139 is unfortunatelly always True for L10nObjects. Because of that, we should first of all check for EntityLists and L10nObjects, and only after that do the rest.
|
Reporter | |
Updated•15 years ago
|
Attachment #363003 -
Flags: review?(gandalf)
|
||
Comment 1•15 years ago
|
||
Comment on attachment 363003 [details] [diff] [review] patch which does proper object type detection stupid me. Thanks!
Attachment #363003 -
Flags: review?(gandalf) → review+
|
|
||
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•