479232 - Engines.get("tabs") is undefined

Status: RESOLVED FIXED

(Cloud Services :: General, defect)

Description

[Darren Worrall]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6 (.NET CLR 3.5.30729)

Server: b2613f8cdb48
Client: 0.2.101  

Just got prompted for 0.2.101, after update, Weave falls over immediately moaning about the tabs engine:

Service.Main	DEBUG	Caught exception: Engines.get("tabs") is undefined (module:service.js:850 :: TypeError)

Doesn't go any further, just falls over in a heap. Updated my server to tip in case I was missing something there, but I'm not.

Attaching verbose log.



Reproducible: Always

Steps to Reproduce:
1. Install 0.2.101
2. Initiate sync (if not automatic)

Comment 1

[Darren Worrall]

Attachment: Verbose log of error

Comment 2

[Darren Worrall]

Forgot to say, enabling/disabling tabs in preferences doesn't make a difference.

Comment 3

[Ryan Steele]

I can confirm on
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6 (.NET CLR 3.5.30729)

Problem does NOT occur on

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b3pre) Gecko/20090218 Shiretoko/3.1b3pre (.NET CLR 3.5.30729)

or

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6 (.NET CLR 3.5.30729)

Comment 4

[Tianon Gravi]

I'm having the exact same issue on Gentoo.  Updated my own server to most recent just the other day for some other Weave update.

Comment 5

[Dan Mills [:thunder]]

The underlying problem here is that Weave doesn't (and won't) support Firefox 3.0.  Weave requires 3.1.

I will change the minVersion to reflect that, but this bug is WONTFIX, sorry.

Comment 6

[Tianon Gravi]

Oh, well that's good to know.  Any particular reason for requiring 3.1?  Especially considering that 3.0 is the latest stable?  Have a link that explains these questions?  That would probably be a good thing to mention on the home page at https://services.mozilla.com/ including a link to this theoretical page explaining why (even if it's very technical).

Comment 7

[vladimir bormotov]

the same error.

Mozilla/5.0 (Windows; U; Windows NT 5.1; ru; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6 (.NET CLR 3.5.30729)

Comment 8

[Dan Mills [:thunder]]

There were history db changes that make it impossible to make it work in 3.0 (without having a separate backend for it, which we won't do).

It looks like tabs is not correctly loading on 3.1, and if someone wants to debug that and it's easy, I would not be opposed to landing a fix for it.

For the narrow error case described in this bug where Engines.get("tabs") is undefined and causing an error, I've committed a fix (so this bug, when narrowly defined, is fixed, not wontfix).

Comment 9

[Dan Mills [:thunder]]

The specific error in this bug is fixed here:

http://hg.mozilla.org/labs/weave/rev/f7c5c7ddb1ce

Comment 10

[Darren Worrall]

Dan - Would it be a better solution to simply disable the history engine on 3.0 for now - at least until 3.1 is released - rather than effectively locking those of us running 3.0 out?

I am unable to run 3.1 at the moment (at least in most places), but would like to continue testing Weave, and the server.

Comment 11

[Dan Mills [:thunder]]

The history engine (and apparently the tabs engine as well) won't work on 3.0 already, it's not a matter of them being enabled or not.

The bigger problem is that no core Weave contributors test with 3.0 at all, so claiming any sort of support is a risky proposition.

You are more than welcome to continue to run Weave on 3.0, just disable the extension compatibility check.  Open about:config, set "extensions.checkCompatibility" (bool) to false.  Restart Firefox.

Comment 12

[Darren Worrall]

Ok, thanks for that :)