sizemode="maximized" does not work well on desktop

VERIFIED FIXED

Status

Firefox for Android Graveyard
General
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

Trunk
x86
Windows XP

Details

Attachments

(1 attachment, 1 obsolete attachment)

We changed to use sizemode="maximized" so the window filled the device screen. This doesn't work so well on desktop.

Patch uses sizemode for mobile platforms and a fixed width/height for desktops
(Assignee)

Comment 1

10 years ago
Created attachment 363248 [details] [diff] [review]
patch

hmm, the patch didn't make it the first time
Assignee: nobody → mark.finkle
Attachment #363248 - Flags: review?(gavin.sharp)
(Assignee)

Updated

10 years ago
Attachment #363248 - Attachment is patch: true
Attachment #363248 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 363248 [details] [diff] [review]
patch

>diff --git a/chrome/content/browser.xul b/chrome/content/browser.xul

>+#ifdef WINCE || MOZ_PLATFORM_HILDON

Does this "||" actually work? I haven't seen this syntax used for the preprocessor anywhere else, and see no mention of it in the current python script/test or the old perl preprocessor docs.
(Assignee)

Comment 3

10 years ago
Created attachment 363322 [details] [diff] [review]
with the right conditionals

Uses the correct conditionals. Gavin is correct, no complex conditional tests are supported. Dumb luck made my build work as expected.
Attachment #363248 - Attachment is obsolete: true
Attachment #363322 - Flags: review?(gavin.sharp)
Attachment #363248 - Flags: review?(gavin.sharp)
Attachment #363322 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 4

10 years ago
http://hg.mozilla.org/mobile-browser/rev/d7c72600678e
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
verified fixed in 20091001 1.9.2 b4 on my mac 10.5
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.