479308 - tinderbox error log highlighting should highlight TinderboxPrint:FAIL: Busted: ts

Status: RESOLVED WONTFIX

(Webtools Graveyard :: Tinderbox, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

When the startup test fails, it prints:

TinderboxPrint:FAIL: Busted: ts

TinderboxPrint:FAIL: failed to initialize browser

...for example, in http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1235077383.1235080074.5935.gz .  The error highlighting doesn't flag this, though, so nothing appears in the error summary at the top of the log.

Either the error parsing should be adjusted to catch this or the test should be adjusted to print something that the error parsing does catch.

Comment 1

[cls]

Attachment: v1.0

FAIL is pretty clearly an error condition.  I'm fine with adding it to the parsers.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Is that going to catch too much?

I'm probably not the right reviewer for this.  Others have actually thought about this code (e.g., ted.mielczarek).

Comment 3

[(not currently active) Ted Mielczarek]

I suggested something similar in bug 474950 comment 3, but I can't say I've studied all the failure cases. It would be good to give our build and unittest logs a once-over to make sure that this isn't going to trip any false positives. I know we've had false positives with Error: in the past.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 366738 [details] [diff] [review]
v1.0

I pored over some logs, and this should be harmless, given how specific it is.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Tinderbox isn't maintained anymore. Closing.