479345 - Error when submit the setting of Edit Group Access Controls

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Lei Lin]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6 (.NET CLR 3.5.30729)
Build Identifier: 

The version of the Bugzilla server is 3.3.3+.
After setting the options in the group access control page, click the submit button, then a 500 Internal Server Error is produced.

Reproducible: Always

Steps to Reproduce:
1.Open the Edit Group Access Controls page for any product.
2.Do some change or just left it as original.
3.Click the submit button.
Actual Results:  
500 Internal Server Error

Expected Results:  
The group access control setting is saved correctly.

Checked the log file of Apache Server (httpd_error.log), found the following output:

[error] Can't call method "group_controls" on an undefined value at /usr/local/www/bugzilla/Bugzilla/Product.pm line 256, <DATA> line 275.\n

Comment 1

[Frédéric Buclin]

Yes, I can reproduce on tip. 3.2 is not affected.

Comment 2

[Frédéric Buclin]

Found the culprit. This is a regression due to bug 371995. I have a patch.

Comment 3

[Frédéric Buclin]

Attachment: patch, v1

Bugzilla::Object->update returns both changes and the old object, but Bugzilla::Field::Choice->update only returns changes, making the caller get an undefined old object.

Comment 4

[Frédéric Buclin]

The initial implementation in bug 455641 regressed this.

Comment 5

[Frédéric Buclin]

Attachment: patch, v1.1

Hum, we have to make sure what the caller wants.

Comment 6

[Max Kanat-Alexander]

Comment on attachment 363236 [details] [diff] [review]
patch, v1.1

Looks right to me.

Comment 7

[Frédéric Buclin]

Checking in Bugzilla/Field/Choice.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Field/Choice.pm,v  <--  Choice.pm
new revision: 1.9; previous revision: 1.8
done