479373 - Hang on shutdown if there are outstanding SSL requests, low cpu

Status: RESOLVED WORKSFORME

(Core :: Security: PSM, defect)

Description

[Jesse Ruderman]

Attachment: testcase (requires Quitter for quit timing)

1. Temporarily install Quitter from 
      https://www.squarefree.com/extensions/quitter.xpi
2. Load the testcase (this will cause Firefox to exit)

Result: hang during shut down

Expected: clean shut down

Comment 1

[Jesse Ruderman]

Attachment: sample

CPU usage is low, so I'm guessing this is a deadlock.

The main thread seems to be waiting for the PSM thread (nsPSMBackgroundThread::requestExit), and maybe the PSM thread is waiting for the main thread (nsComponentManagerImpl::CreateInstanceByContractID).

Comment 2

[Jesse Ruderman]

I'm hitting this a lot when fuzzing.  It's slowing me down quite a big.

Comment 3

[Jesse Ruderman]

Anecdotal evidence suggests that lots of users are hitting the "Firefox is already running, but is not responding" dialog, which indicates either a shutdown hang or a lock-management bug.  This bug has a reproducible testcase and could plausibly be responsible for some of the pain users are experiencing.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I agree with Jesse, shutdown hangs is something we know is biting our users, and this could very well be a source of these.

Seems like we should fix this for 1.9.3.

Comment 5

[David :Bienvenu]

I believe Thunderbird is susceptible to this, especially with IMAP and LDAP

Comment 6

[Jesse Ruderman]

Attachment: testcase 2 (requires DOMFuzzLite for quit timing)

Comment 7

[Jesse Ruderman]

WFM on trunk with both testcases.  Tested on Mac OS X 10.5.x.

Comment 8

[Jesse Ruderman]

Attachment: testcase 3 (requires DOMFuzzLite for quit timing)

Comment 9

[Jesse Ruderman]

WFM on Linux too, fwiw.

Comment 10

[Wayne Mery (:wsmwk)]

bienvenu in comment #5
> I believe Thunderbird is susceptible to this, especially with IMAP and LDAP

yes. 

from this list of shutdown hangs [1], which ones should be marked blocked by this bug?  Or is there no good, representative bug open?

[1] https://bugzilla.mozilla.org/buglist.cgi?type1-0-0=anywordssubstr&keywords=hang&keywords_type=allwords&short_desc=shut&field0-0-0=short_desc&resolution=---&classification=Client%20Software&classification=Components&query_format=advanced&short_desc_type=allwordssubstr&type0-0-0=nowords&value0-0-0=count%20counts&field1-0-0=short_desc&product=MailNews%20Core&product=Thunderbird

Comment 11

[Wayne Mery (:wsmwk)]

sorry, firefox session restore is mucking with bugzilla fields again. I didn't touch them.

bievenu, I guess this means we take a different path. Cursory examination doesn't find other ssl hang bugs for core.

Comment 12

[David :Bienvenu]

Wayne, I'm not sure any of those bugs involve an open ldap connection at shutdown time, though I think Standard8 might have one...