Closed
Bug 479389
Opened 16 years ago
Closed 16 years ago
Incorrect quoting when calling GetLongPath macro
Categories
(Firefox :: Installer, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3.1b3
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
Details
(Keywords: fixed1.9.1)
Attachments
(1 file, 1 obsolete file)
1.08 KB,
patch
|
jimm
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
This is minor since it doesn't appear to have an adverse affect and fixing it is for correctness
Attachment #363267 -
Flags: review?(jmathies)
![]() |
Assignee | |
Comment 1•16 years ago
|
||
bah, I didn't notice the string comparison wasn't quoted as well
Attachment #363267 -
Attachment is obsolete: true
Attachment #363268 -
Flags: review?(jmathies)
Attachment #363267 -
Flags: review?(jmathies)
![]() |
||
Updated•16 years ago
|
Attachment #363268 -
Flags: review?(jmathies) → review+
![]() |
Assignee | |
Comment 2•16 years ago
|
||
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/354188c61081
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
![]() |
Assignee | |
Updated•16 years ago
|
Attachment #363268 -
Flags: approval1.9.1?
![]() |
Assignee | |
Comment 3•16 years ago
|
||
Comment on attachment 363268 [details] [diff] [review]
patch rev2
Drivers, this is a no brainer fix where params weren't quoted correctly.
Comment 4•16 years ago
|
||
Comment on attachment 363268 [details] [diff] [review]
patch rev2
a191=beltzner
Attachment #363268 -
Flags: approval1.9.1? → approval1.9.1+
![]() |
Assignee | |
Comment 5•16 years ago
|
||
Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/d053793b2618
Keywords: fixed1.9.1
Target Milestone: --- → Firefox 3.1b3
You need to log in
before you can comment on or make changes to this bug.
Description
•