Closed Bug 479389 Opened 16 years ago Closed 16 years ago

Incorrect quoting when calling GetLongPath macro

Categories

(Firefox :: Installer, defect)

3.5 Branch
x86
Windows Vista
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Firefox 3.1b3

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

(Keywords: fixed1.9.1)

Attachments

(1 file, 1 obsolete file)

Attached patch patch rev1 (obsolete) — Splinter Review
This is minor since it doesn't appear to have an adverse affect and fixing it is for correctness
Attachment #363267 - Flags: review?(jmathies)
Attached patch patch rev2Splinter Review
bah, I didn't notice the string comparison wasn't quoted as well
Attachment #363267 - Attachment is obsolete: true
Attachment #363268 - Flags: review?(jmathies)
Attachment #363267 - Flags: review?(jmathies)
Attachment #363268 - Flags: review?(jmathies) → review+
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Attachment #363268 - Flags: approval1.9.1?
Comment on attachment 363268 [details] [diff] [review] patch rev2 Drivers, this is a no brainer fix where params weren't quoted correctly.
Comment on attachment 363268 [details] [diff] [review] patch rev2 a191=beltzner
Attachment #363268 - Flags: approval1.9.1? → approval1.9.1+
Keywords: fixed1.9.1
Target Milestone: --- → Firefox 3.1b3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: