Closed Bug 479421 Opened 15 years ago Closed 15 years ago

saner default handling for sizemode in SM sessionstore

Categories

(SeaMonkey :: Session Restore, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0b1

People

(Reporter: misak.bugzilla, Assigned: misak.bugzilla)

References

Details

Attachments

(1 file)

This is port of part of bug 477657, which is landed by another checkin (bug 476463). Some related comments from there:

Omitting a window's sizemode property should preserve the current state (and
not restore to a non-maximized, non-minimized state).
Attachment #363295 - Flags: superreview?(neil)
Attachment #363295 - Flags: review?(neil)
Assignee: nobody → misak
Status: NEW → ASSIGNED
Attachment #363295 - Flags: superreview?(neil)
Attachment #363295 - Flags: superreview+
Attachment #363295 - Flags: review?(neil)
Attachment #363295 - Flags: review+
Comment on attachment 363295 [details] [diff] [review]
patch
[Checkin: Comment 2]

>-    case "maximized":
>-       if (win_("sizemode") != "maximized")
>-         aWindow.maximize();
>-    break
>-    case "minimized":
>-       if (win_("sizemode") != "minimized")
>-         aWindow.minimize();
>-       break
>-    default:
>-       if (win_("sizemode") != "normal")
>-         aWindow.restore();
>-       break
Whoa, the coding style here is all out of whack. I want to get rid of it ASAP!
Keywords: checkin-needed
Comment on attachment 363295 [details] [diff] [review]
patch
[Checkin: Comment 2]


http://hg.mozilla.org/comm-central/rev/2532cb89212e
Attachment #363295 - Attachment description: patch → patch [Checkin: Comment 2]
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Depends on: 477657, 476463
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b1
Component: General → Session Restore
QA Contact: general → session.restore
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: