saner default handling for sizemode in SM sessionstore

RESOLVED FIXED in seamonkey2.0b1

Status

SeaMonkey
Session Restore
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Misak Khachatryan, Assigned: Misak Khachatryan)

Tracking

Trunk
seamonkey2.0b1
x86
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.13 KB, patch
neil@parkwaycc.co.uk
: review+
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
Created attachment 363295 [details] [diff] [review]
patch
[Checkin: Comment 2]

This is port of part of bug 477657, which is landed by another checkin (bug 476463). Some related comments from there:

Omitting a window's sizemode property should preserve the current state (and
not restore to a non-maximized, non-minimized state).
Attachment #363295 - Flags: superreview?(neil)
Attachment #363295 - Flags: review?(neil)
(Assignee)

Updated

9 years ago
Assignee: nobody → misak
Status: NEW → ASSIGNED

Updated

9 years ago
Attachment #363295 - Flags: superreview?(neil)
Attachment #363295 - Flags: superreview+
Attachment #363295 - Flags: review?(neil)
Attachment #363295 - Flags: review+

Comment 1

9 years ago
Comment on attachment 363295 [details] [diff] [review]
patch
[Checkin: Comment 2]

>-    case "maximized":
>-       if (win_("sizemode") != "maximized")
>-         aWindow.maximize();
>-    break
>-    case "minimized":
>-       if (win_("sizemode") != "minimized")
>-         aWindow.minimize();
>-       break
>-    default:
>-       if (win_("sizemode") != "normal")
>-         aWindow.restore();
>-       break
Whoa, the coding style here is all out of whack. I want to get rid of it ASAP!
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
Comment on attachment 363295 [details] [diff] [review]
patch
[Checkin: Comment 2]


http://hg.mozilla.org/comm-central/rev/2532cb89212e
Attachment #363295 - Attachment description: patch → patch [Checkin: Comment 2]
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Depends on: 477657, 476463
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b1

Updated

9 years ago
Component: General → Session Restore
QA Contact: general → session.restore
You need to log in before you can comment on or make changes to this bug.