479456 - abcdump doesn't show all the mops opcodes that the verifier sees

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect, P1)

Description

[Edwin Smith]

abcdump test/acceptance/mops/mops.abc_ 

tested:
li8
si8

not tested:
li16
li32
lf32
lf64
si16
si32
sf32
sf64
sxi1
sxi8
sxi16

Comment 1

[Steven Johnson]

Are we positive that's accurate? I have a (vague) memory of finding a byte-swap bug in MOPS using that testcase, which wouldn't turn up if we were only using the li8/si8 ops...

Comment 2

[Edwin Smith]

i stand corrected, abcdump is broken.  subject edited.

Comment 3

[Edwin Smith]

Attachment: ensure every method is dumped, other tweaks

add -abs option to produce abcasm compatible output

refactor doExtract* flags to make them orthogonal.  doExtractAbs=true means generate abcasm compatible output, doExtractInfo means generate extra info.  (both default true).  

if both are enabled, infoPrint() generates // in front of extra info.

fixed bug where not every function referenced by OP_newfunction would be dumped.  Now, we dump all methods (script, instance, class methods), followed by all other functions.  It is possible that even methods never referenced by any trait or any OP_newfunction will also be dumped.

Functions not referenced by a Trait entry don't have a name, and used to print as "function undefined(...)", now they print as "function(...)", like anonymous functions in js.

InstanceInfo, ClassInfo, and MethodBodies stats now includes both count and size.

Comment 4

[Tom Harwood]

Review + (bugzilla won't let me change the setting directly)

- Seems like the dump flags setttings are headed for difficulties, it's already necessary to cross-reference to see which setting turns on which flag.
- Some tab-expansion issues
- 917, dumpPrint always preceeded by an abcasm EOL comment -- should only do when -abs flag is on?

Comment 5

[Lars T Hansen]

Comment on attachment 363669 [details] [diff] [review]
ensure every method is dumped, other tweaks

(setting tom's flag for him)

Comment 6

[Edwin Smith]

pushed http://hg.mozilla.org/tamarin-redux/rev/ee4957dcf3ed

Comment 7

[Chris Peyer]

Resolved fixed engineering / work item that has been pushed.  Setting status to verified.

Comment 8

[Chris Peyer]

Removing in-testsuite flag after verifying with Edwin Smith that no test media needed.