Closed Bug 479543 Opened 15 years ago Closed 15 years ago

mozStorageConnection::Close should use NS_ERROR instead of NS_WARNING to complain about unfinalized statements

Categories

(Toolkit :: Storage, defect)

Product:
Toolkit
Component:
Storage
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: sdwilsh, Assigned: RyanVM)

Details

Attachments

(1 file, 1 obsolete file)

Now with less breakage [Checkin: Comment 8]
823 bytes, patch
sdwilsh
: review+
Details | Diff | Splinter Review 
mozStorageConnection::Close should use NS_ERROR instead of NS_WARNING to complain about unfinalized statements
Whiteboard: [good first bug]
Attached patch That was easy (obsolete) — — Splinter Review 
Here you go
Assignee: nobody → ryanvm
Attachment #363443 - Flags: review?
Attachment #363443 - Flags: review? → review?(sdwilsh)
Attachment #363443 - Flags: review?(sdwilsh) → review+
Comment on attachment 363443 [details] [diff] [review]
That was easy

r=sdwilsh
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/f8926cd4a7b2
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Had to back this out since it completely breaks unit tests on debug builds (FTS makes us assert).

We only want the second NS_ERROR, not the first one (that's what triggers the assert).

http://hg.mozilla.org/mozilla-central/rev/0e56b82242f2
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Of course, I probably should have just fixed this myself...
*sigh*
Attachment #363443 - Attachment is obsolete: true
Attachment #364632 - Flags: review?(sdwilsh)
Attachment #364632 - Flags: review?(sdwilsh) → review+
Comment on attachment 364632 [details] [diff] [review]
Now with less breakage
[Checkin: Comment 8]

r=sdwilsh
Keywords: checkin-needed
Comment on attachment 364632 [details] [diff] [review]
Now with less breakage
[Checkin: Comment 8]


http://hg.mozilla.org/mozilla-central/rev/fba5db545afa
Attachment #364632 - Attachment description: Now with less breakage → Now with less breakage [Checkin: Comment 8]
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [good first bug]
No need for docs on this.
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: