479588 - Error console's text box should always be LTR

Status: RESOLVED FIXED

(Toolkit Graveyard :: Error Console, defect)

Description

[(no longer active)]

Error console's text box should always be LTR, even for RTL elements, because the code entered into it is LTR.  We should probably add the uri-element class to it.  Patch forthcoming.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 363471 [details] [diff] [review]
Patch (v1)

That line should wrap. While you're at it, you could add a semicolon in onkeypress and remove value="".

Comment 3

[Dão Gottwald [:dao]]

Personally I'd rather make it LTR in components/console/content/console.css. uri-element isn't quite right, although I don't foresee that this could cause any trouble.

Comment 4

[(no longer active)]

Attachment: Patch (v2)

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 366197 [details] [diff] [review]
Patch (v2)

I think you want #TextboxEval, and there's probably no need for !important.

Comment 6

[(no longer active)]

Attachment: Patch (v3)

Yes, you're right.

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/6760e7395b5a

Comment 8

[(no longer active)]

Comment on attachment 366200 [details] [diff] [review]
Patch (v3)

Small theme-only change useful for RTL locales.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 366200 [details] [diff] [review]
Patch (v3)

a191=beltzner

Comment 10

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4a5a67404091