Last Comment Bug 479588 - Error console's text box should always be LTR
: Error console's text box should always be LTR
Status: RESOLVED FIXED
: fixed1.9.1, rtl
Product: Toolkit Graveyard
Classification: Graveyard
Component: Error Console (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla1.9.2a1
Assigned To: :Ehsan Akhgari
:
:
Mentors:
Depends on:
Blocks: intl.css-cleanup
  Show dependency treegraph
 
Reported: 2009-02-21 04:44 PST by :Ehsan Akhgari
Modified: 2016-06-29 11:02 PDT (History)
4 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (v1) (815 bytes, patch)
2009-02-21 05:28 PST, :Ehsan Akhgari
dao+bmo: review+
Details | Diff | Splinter Review
Patch (v2) (413 bytes, patch)
2009-03-08 10:13 PDT, :Ehsan Akhgari
dao+bmo: review-
Details | Diff | Splinter Review
Patch (v3) (406 bytes, patch)
2009-03-08 10:49 PDT, :Ehsan Akhgari
dao+bmo: review+
mbeltzner: approval1.9.1+
Details | Diff | Splinter Review

Description User image :Ehsan Akhgari 2009-02-21 04:44:45 PST
Error console's text box should always be LTR, even for RTL elements, because the code entered into it is LTR.  We should probably add the uri-element class to it.  Patch forthcoming.
Comment 1 User image :Ehsan Akhgari 2009-02-21 05:28:46 PST
Created attachment 363471 [details] [diff] [review]
Patch (v1)
Comment 2 User image Dão Gottwald [:dao] 2009-02-21 05:39:28 PST
Comment on attachment 363471 [details] [diff] [review]
Patch (v1)

That line should wrap. While you're at it, you could add a semicolon in onkeypress and remove value="".
Comment 3 User image Dão Gottwald [:dao] 2009-02-21 05:42:13 PST
Personally I'd rather make it LTR in components/console/content/console.css. uri-element isn't quite right, although I don't foresee that this could cause any trouble.
Comment 4 User image :Ehsan Akhgari 2009-03-08 10:13:16 PDT
Created attachment 366197 [details] [diff] [review]
Patch (v2)
Comment 5 User image Dão Gottwald [:dao] 2009-03-08 10:38:41 PDT
Comment on attachment 366197 [details] [diff] [review]
Patch (v2)

I think you want #TextboxEval, and there's probably no need for !important.
Comment 6 User image :Ehsan Akhgari 2009-03-08 10:49:35 PDT
Created attachment 366200 [details] [diff] [review]
Patch (v3)

Yes, you're right.
Comment 8 User image :Ehsan Akhgari 2009-03-08 14:16:19 PDT
Comment on attachment 366200 [details] [diff] [review]
Patch (v3)

Small theme-only change useful for RTL locales.
Comment 9 User image Mike Beltzner [:beltzner, not reading bugmail] 2009-03-27 10:23:17 PDT
Comment on attachment 366200 [details] [diff] [review]
Patch (v3)

a191=beltzner

Note You need to log in before you can comment on or make changes to this bug.