The default bug view has changed. See this FAQ.

Error console's text box should always be LTR

RESOLVED FIXED in mozilla1.9.2a1

Status

Toolkit Graveyard
Error Console
RESOLVED FIXED
8 years ago
9 months ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

(Blocks: 1 bug, {fixed1.9.1, rtl})

Trunk
mozilla1.9.2a1
fixed1.9.1, rtl

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

8 years ago
Error console's text box should always be LTR, even for RTL elements, because the code entered into it is LTR.  We should probably add the uri-element class to it.  Patch forthcoming.
(Assignee)

Comment 1

8 years ago
Created attachment 363471 [details] [diff] [review]
Patch (v1)
Attachment #363471 - Flags: review?(dao)

Updated

8 years ago
Attachment #363471 - Flags: review?(dao) → review+
Comment on attachment 363471 [details] [diff] [review]
Patch (v1)

That line should wrap. While you're at it, you could add a semicolon in onkeypress and remove value="".
Personally I'd rather make it LTR in components/console/content/console.css. uri-element isn't quite right, although I don't foresee that this could cause any trouble.
(Assignee)

Comment 4

8 years ago
Created attachment 366197 [details] [diff] [review]
Patch (v2)
Attachment #363471 - Attachment is obsolete: true
Attachment #366197 - Flags: review?(dao)

Updated

8 years ago
Attachment #366197 - Flags: review?(dao) → review-
Comment on attachment 366197 [details] [diff] [review]
Patch (v2)

I think you want #TextboxEval, and there's probably no need for !important.
(Assignee)

Comment 6

8 years ago
Created attachment 366200 [details] [diff] [review]
Patch (v3)

Yes, you're right.
Attachment #366197 - Attachment is obsolete: true
Attachment #366200 - Flags: review?(dao)

Updated

8 years ago
Attachment #366200 - Flags: review?(dao) → review+
(Assignee)

Comment 7

8 years ago
http://hg.mozilla.org/mozilla-central/rev/6760e7395b5a
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
(Assignee)

Comment 8

8 years ago
Comment on attachment 366200 [details] [diff] [review]
Patch (v3)

Small theme-only change useful for RTL locales.
Attachment #366200 - Flags: approval1.9.1?
Comment on attachment 366200 [details] [diff] [review]
Patch (v3)

a191=beltzner
Attachment #366200 - Flags: approval1.9.1? → approval1.9.1+
(Assignee)

Comment 10

8 years ago
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/4a5a67404091
Keywords: fixed1.9.1
(Assignee)

Updated

8 years ago
Blocks: 486822

Updated

8 years ago
No longer blocks: 486822

Updated

8 years ago
Blocks: 486822
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.