about:rights infobar and about:right page use "open software" and "open source software" inconsistently

VERIFIED FIXED in Firefox 3.6a1

Status

()

Firefox
General
P2
minor
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: davida, Assigned: beltzner)

Tracking

({late-l10n, verified1.9.1})

unspecified
Firefox 3.6a1
late-l10n, verified1.9.1
Points:
---
Bug Flags:
blocking-firefox3.5 -
wanted-firefox3.5 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
Created attachment 363520 [details]
screenshot (mac)

In http://mxr.mozilla.org/comm-central/source/mozilla/browser/locales/en-US/chrome/browser/aboutRights.dtd#5

we have:

  <!ENTITY rights.intro "&brandFullName; is free and open source software, built by a community of thousands from all over the world. There are a few things you should know:">

but in http://mxr.mozilla.org/comm-central/source/mozilla/browser/locales/en-US/chrome/browser/aboutRights.properties?raw=1&ctype=

we have:

  notifyText = %S is free and open software from the non-profit Mozilla Foundation.

Note "open software", not open source software.  I'm suspecting that that's not an intentional difference, and that the latter should read "open source software".

(Cc'ing some of the Tb drivers as Thunderbird has the same bug, and probably wants to follow whatever is decided here.)

(I didn't check to see if this was fixed in the 1.9.1 branch, as mxr on that branch isn't working for me right now)
Flags: blocking-firefox3.1?

Updated

9 years ago
Attachment #363520 - Attachment mime type: application/octet-stream → image/png
http://mxr.mozilla.org/mozilla1.9.1/source/browser/locales/en-US/chrome/browser/aboutRights.properties?raw=1&ctype=

says:

notifyText = %S is free and open software from the non-profit Mozilla Foundation.

which is the text as given in bug 456439 (see attachment 339841 [details]). Changing it would be late-l10n if we take it for Firefox 3.1, which is doable, we just need to know right away.

Harvey/Kev: any strong opinions here? I actually thought "free and open" was intentional (and fine on its own) but I suppose we ought to be consistent.
Keywords: late-l10n
Summary: about:rights info-bar says "open software", not "open source software" → about:rights infobar and about:right page use "open software" and "open source software" inconsistently

Comment 2

9 years ago
Prefer "free and open source software" and "...built by a community of thousands..."

/hja
Don't think this blocks, but I'll fix it tomorrow.
Assignee: nobody → beltzner
Flags: wanted-firefox3.1+
Flags: blocking-firefox3.1?
Flags: blocking-firefox3.1-
Priority: -- → P2
(Reporter)

Updated

9 years ago
Blocks: 480127
Created attachment 364151 [details] [diff] [review]
free and open source software

Wording fix as per hja's comment. Also renamed the entity and had to adjust some spacing.
Attachment #364151 - Flags: superreview?
Attachment #364151 - Flags: review?(gavin.sharp)
Attachment #364151 - Flags: superreview? → superreview?(l10n)

Comment 5

9 years ago
Comment on attachment 364151 [details] [diff] [review]
free and open source software

I'm not a superreviewer, but I'm happily granting an additional review on this patch.
Attachment #364151 - Flags: superreview?(l10n) → review+
Attachment #364151 - Flags: review?(gavin.sharp) → review+
Yeah, I was looking for l10n-happy-stamp, really, to make sure you agreed we needed to rev the entity. Thanks.

Marking checkin-needed, as Daddy doesn't let me have checkin access.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ee49a98d2646
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Attachment #364151 - Flags: approval1.9.1?
Comment on attachment 364151 [details] [diff] [review]
free and open source software

a191=beltzner
Attachment #364151 - Flags: approval1.9.1? → approval1.9.1+
Keywords: checkin-needed
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f071b8ea6ba7
Keywords: checkin-needed → fixed1.9.1
Target Milestone: Firefox 3.1b3 → Firefox 3.2a1
verified FIXED on builds:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2pre)
Gecko/20090727 Shiretoko/3.5.2pre ID:20090727031954

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre)
Gecko/20090727 Minefield/3.6a1pre ID:20090727031437
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1
You need to log in before you can comment on or make changes to this bug.