479647 - remove intl.charset.default from navigator.properties

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Robert Kaiser]

I just did a search for intl.charset.default on MXR:
http://mxr.mozilla.org/comm-central/search?string=intl.charset.default
and I found that we set a value for it in /suite/locales/en-US/chrome/browser/<platform>/navigator.properties but we never use that value anywhere, we're only using the intl.properties value. We should clean that up.

Comment 1

[Philip Chee]

Err, Your MXR query shows that we do in:
http://mxr.mozilla.org/comm-central/source/suite/browser/src/nsInternetSearchService.cpp#3521
And so does editor, and so does toolkit, and so does Gecko.

Comment 2

[Philip Chee]

Sorry misread your comment.

Comment 3

[Edmund Wong (:ewong)]

Attachment: Removed intl.charset.default from navigator.properties.

Comment 4

[[e-mail]]

I see no reason to keep the file.

Comment 5

[Edmund Wong (:ewong)]

Attachment: Removed navigator.properties.

Comment 6

[[e-mail]]

Comment on attachment 523987 [details] [diff] [review]
Removed navigator.properties.

>-  locale/@AB_CD@/navigator/navigator.properties                             (%chrome/browser/navigator.properties)
We want to keep this one!

Comment 7

[Edmund Wong (:ewong)]

Attachment: Removed navigator.properties. (v2)

Comment 8

[Philip Chee]

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/d63cd40a3051

Comment 9

[Philip Chee]

Pushed to comm-2.0
http://hg.mozilla.org/releases/comm-2.0/rev/c2d9b5a34028

Comment 10

[Stefan [:stefanh]]

(In reply to comment #9)
> Pushed to comm-2.0
> http://hg.mozilla.org/releases/comm-2.0/rev/c2d9b5a34028

Hmm, what about the string freeze?

Comment 11

[Philip Chee]

Oops. Backing out.
Back out changeset:
http://hg.mozilla.org/releases/comm-2.0/rev/feda69146135