Closed Bug 479705 Opened 15 years ago Closed 15 years ago

Slow script warnings on bloat tests

Categories

(MailNews Core :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files)

Attached patch The fixSplinter Review
We've been seeing some slow script warnings on the trunk bloat tests - this is when we're running with trace malloc which is really slow. I'm guessing something has changed recently which has made it slightly slower.

I've taken a look at the Firefox bloat tests and they disable the slow script warning dialogs, I think we should do the same.

Attaching a patch which will add the disabling to the script, additionally it will disable the search integration prompt if the tests are run manually on vista (our automated test boxes are on Win2k3 at the moment).
Attachment #363598 - Flags: review?(bienvenu)
Attachment #363598 - Flags: review?(bienvenu) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/720d3a1ea63d
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Not quite good enough. We need to set dom.max_chrome_script_run_time as well.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
We also need this - the same as the other but for chrome. I've done the same as what FF do here - set it to 10x its default value (20) when doing debug builds.

Conceivably we may not want this set in common all the time, but for now its good enough (and the warnings are killing the vms).
Attachment #363721 - Flags: review?(bienvenu)
Attachment #363721 - Flags: review?(bienvenu) → review+
Second patch checked in: http://hg.mozilla.org/comm-central/rev/d482f37dc46a

Hopefully this fixes the issue now.
Status: REOPENED → RESOLVED
Closed: 15 years ago15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.