479707 - Error notification dialog: "Error number" should be "Error code"

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Robert Brand]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090220 Calendar/1.0pre

With the revised provider error notifications from Bug 392561 errors I see don't have numbers anymore, but are something like UTF8_DECODING_FAILED or MODIFICATION_FAILED. In such cases the string "Error number" in the error dialog looks strange.
I'd suggest to call it "Error code" as it is called in corresponding message in the error console.

Reproducible: Always

Steps to Reproduce:
1. Subscribe to a remote calendar (ICS) you don't have write access to.
2. Try to create a new event in this calendar.
3. Have a look at the error notification and into the error console.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

Comment 2

[Martin Schröder [:mschroeder]]

Comment on attachment 363605 [details] [diff] [review]
Fix - v1

Stealing review.  ;) r=mschroeder

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/3dd8f05f37cf>

-> FIXED

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".