479868 - Buttons do not become inactive on Affiliates Page

Status: VERIFIED FIXED

(Websites Graveyard :: spreadfirefox.com, defect)

Description

[Laura Mesa [:lmesa] [:lvmesa]]

Alex,

Every time I try to make a button "inactive" in the administration portal, I still see the button when I log out and look in the Frisian category as a regular sfx user.  I'd like these buttons to not be seen when made inactive.  I'd also like a way to delete buttons once they become obsolete. 

Thanks.

Comment 1

[Alex Buchanan [:abuchanan]]

Adding this to the next planned SFx milestone.  Sorry this fell off the radar with the site redesign.

Could you file a separate bug for delete functionality, please?

Thanks!

Comment 2

[Alex Buchanan [:abuchanan]]

r26509 fixed this.

The problem was that we were showing all buttons, not just the active ones.

so, STR on stage...

1) http://spreadfirefox.authstage.mozilla.com/admin/affiliates/button/edit/306
2) make the button inactive
3) https://spreadfirefox.authstage.mozilla.com/affiliates/homepage
4) notice the button is still there

expected result
---------------
when button is inactive, it does not show up publicly

actual result (before fix)
--------------------------
you see the button on the affiliates homepage button browser

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

I can still reproduce this -- staging should be updated, no?

Comment 4

[Alex Buchanan [:abuchanan]]

oops, I pasted the wrong link in the STR,

 1) http://spreadfirefox.authstage.mozilla.com/admin/affiliates/button/edit/2
 2) make the button inactive
 3) https://spreadfirefox.authstage.mozilla.com/affiliates/homepage
 4) notice the button is still there

sorry

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Thx Alex -- verified fixed.