479870 - Anchors are not usable for 'he' localization

Status: VERIFIED DUPLICATE of bug 438265

(support.mozilla.org :: Knowledge Base Software, task)

Description

[Tomer Cohen :tomer]

I have translated the 'Ask a question' article to Hebrew and found that the in-document links do not appear as expected. Instead of linking to the required section, they do link to "#_". 

cilias said this is due to RTL (please fix bug 437891!), but I afraid it is because of the software itself. Please note how wikipedia handle in-document links - It might not be easy as expected, since most of us never use localized anchors.

Here is link to the preview. In the meantime, I have removed any links from that page. You should look for the two links in the first section ("איפה לשאול את השאלה שלך").

http://support.mozilla.com/tiki-pagehistory.php?page=%D7%A9%D7%90%D7%9C+%D7%A9%D7%90%D7%9C%D7%94&preview=1


Thanks.

Comment 1

[David Tenser [:djst]]

Sounds like something we'd like to see fixed as part of the 1.0 milestone.

Comment 2

[Paul Craciunoiu [:paulc]]

I'm not sure how to approach this yet. Seems that the wiki parser is building the anchors wrong. Eric, can you help?

Comment 3

[E. Cooper [:ecooper]]

My RTL troubleshooting experience mostly non-existent. ;)

A lot of stuff looks to be in play with this one. The underscore as the anchor is a symptom of webroot/lib/wiki-plugins/wikiplugin_alink.php:41.

Unfortunately, a similar line of code is currently in use with creation of divs, which means a solution to this is likely to bridge a lot of files used in parsing and display.

I wonder if this is a problem in tiki 2.2?

Comment 4

[E. Cooper [:ecooper]]

An alternative would be to find the sanitizer for the id param of h1, h2, h3, div, etc., tags and match it to the one used in ALINK (or vice versa, but probably using the one in tikilib in ALINK). 

I'm not sure if it would work, but at least then the anchors being created might match the ids being created.

Comment 5

[Paul Craciunoiu [:paulc]]

Yeah, worst case we can temporarily try to skip/replace that for he locale links only. That should work, right?

Comment 6

[Paul Craciunoiu [:paulc]]

By "that" I mean line 41.

Comment 7

[E. Cooper [:ecooper]]

(In reply to comment #5)
> Yeah, worst case we can temporarily try to skip/replace that for he locale
> links only. That should work, right?

Not exactly. It will prevent a truncated anchor, but it won't work anyway because the same thing happens in the heading tags (h2, h3). So, you'll have mismatched ids and nothing will happen.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified duplicate.