Closed Bug 479879 Opened 16 years ago Closed 14 years ago

ExtendedSplitView autosaving is broken

Categories

(Camino Graveyard :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: stuart.morgan+bugzilla, Assigned: alqahira)

Details

Attachments

(1 file)

We're missing a formatter string in the method that returns the name, so different ESVs will stomp each other. I haven't checked if the Cert ESV (the only one other than the location+search field) autosaves, this may not be doing anything bad now, but should be fixed.
Attached patch Fix-ishSplinter Review
(In reply to comment #0)
> I haven't checked if the Cert ESV (the
> only one other than the location+search field) autosaves,

It does autosave[1].  It doesn't appear to stomp because the location+search does not autosave[2] (instead, there we save a width under its own key[3]).

This patch fixes autosaving the name with the "ExtendedSplitView Sizes" key for the I-can't-believe-we-really-named-it-that "CategoriesSplitter" (which also gets a new, more descriptive name, since we've never really been saving it).

However, this patch doesn't fix writing values for the two frames under a  "NSSplitView Subview Frames (null)" key; I'm not sure how to fix that.

[1] http://mxr.mozilla.org/camino/source/camino/src/security/CertificatesWindowController.mm#430
[2] http://mxr.mozilla.org/camino/source/camino/src/browser/BrowserWindowController.mm#954
[3] http://mxr.mozilla.org/camino/source/camino/src/browser/BrowserWindowController.mm#807
Assignee: nobody → alqahira
Status: NEW → ASSIGNED
Attachment #490441 - Flags: superreview?(stuart.morgan+bugzilla)
Comment on attachment 490441 [details] [diff] [review]
Fix-ish

sr=smorgan
Attachment #490441 - Flags: superreview?(stuart.morgan+bugzilla) → superreview+
http://hg.mozilla.org/camino/rev/b22b4a5ed489

(In reply to comment #1)
> However, this patch doesn't fix writing values for the two frames under a 
> "NSSplitView Subview Frames (null)" key; I'm not sure how to fix that.

Filed bug 615766 for that.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: