479938 - Crash [@ nsLineBox::CachedIsEmpty] with -moz-column, huge padding

Status: RESOLVED WORKSFORME

(Core :: Layout: Block and Inline, defect)

Description

[Jesse Ruderman]

Attachment: testcase (crashes Firefox when loaded)

###!!! ASSERTION: Computed overflow area must contain frame bounds: 'aNewSize.width == 0 || aNewSize.height == 0 || aOverflowArea->Contains(nsRect(nsPoint(0, 0), aNewSize))', file /Users/jruderman/central/layout/generic/nsFrame.cpp, line 5618

###!!! ASSERTION: illegal height for combined area: 'aCombinedArea.height >= 0', file /Users/jruderman/central/layout/generic/nsLineBox.cpp, line 499

###!!! ASSERTION: illegal width for combined area: 'aCombinedArea.width >= 0', file /Users/jruderman/central/layout/generic/nsLineBox.cpp, line 498

Null-dereference crash [@ nsLineBox::CachedIsEmpty]

Comment 1

[Mats Palmgren (inactive)]

It's a bug in nsBlockFrame::DoRemoveFrame....

Comment 2

[Mats Palmgren (inactive)]

Attachment: Frame dumps

DoRemoveFrame removes the frame (green) and finds that the line is now
empty so it removes that too, then tries to find the continuation, but
since it's not on the next line we try to advance to the overflow-lines
instead, on line 5526:
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsBlockFrame.cpp#5502
this triggers the code block 5533 - 5537 which sets the next-sibling
of (red) to null. There are no overflow-lines so we fall into the
RemoveBlockChild call at the end, which recursively calls DoRemoveFrame,
(the next frame dump is for this call).  Note the error that frames
on the two lines are not connected with a next-sibling pointer.
The (blue) frame is removed ok and we return (with the last frame
dump as the final resulting frame tree).

The disconnected frames cause problems later in PullFrameFrom:
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsBlockFrame.cpp#2410
which depends on the invariant "when aFromContainer is 'this', then
aLine->LastChild()'s next sibling is already set correctly.", when the
line's child count is incremented on line 2445 the count exceeds
the number of siblings and mayhem ensues...

Comment 3

[Bernd]

wfm 1.9.2

Comment 4

[Jesse Ruderman]

Still crashes for me on mozilla-central.

Comment 5

[Jesse Ruderman]

WFM on mozilla-central now.

Mats, does the issue described in comment 2 still exist?

Comment 6

[Jesse Ruderman]

Added crashtest:

http://hg.mozilla.org/mozilla-central/rev/543def0d7efb