479945 - non-ASCII characters should be decoded in the Bookmarks dialogs

Status: NEW

(SeaMonkey :: Bookmarks & History, defect)

Description

[Misak Khachatryan]

Attachment: patch

This is a Bookmarks part of bug 425480. I think i covered all cases.

Comment 1

[[e-mail]]

Comment on attachment 363853 [details] [diff] [review]
patch

>-      url = getNormalizedURL(gFld_URL.value);
>+      url = encodeURI(gFld_URL.value);
>+      url = getNormalizedURL(url);
There are two problems here:
1. getNormalizedURL needs to run on the value, since its job is to convert a local file path into a URI
2. encodeURI reencodes everything, which breaks already encoded URIs.
3. bookmark keywords need to be able to support %s and %S in bookmark values.
Is it actually necessary to encode the URI here? Presumably the encoded URI will still work when loaded as a URI.

>+  document.getElementById("url").value = BookmarksUtils.losslessDecodeURL(document.getElementById("url").value);
>+
I don't think this change is right.

>+  losslessDecodeURL: function (value)
Should comment that this function is similar to the one in navigator.js (or modify navigator.js to call this version perhaps?)

Comment 2

[Philip Chee]

Erm, or move the navigator version to utilityOverlay.js perhaps?
Or a JSM module?

Comment 3

[Robert Kaiser]

Should be fixed by bug 498596 in current nightlies, SeaMonkey 2.1 Alpha 3 and later - please double-check in such builds.

Comment 4

[Misak Khachatryan]

It's not fixed, location column still show urls like http://ru.wikipedia.org/wiki/%D0%92%D0%BE%D0%B5%D0%BD%D0%BD%D0%B0%D1%8F_%D0%B1%D0%B0%D0%B7%D0%B0_%D0%93%D1%83%D0%B0%D0%BD%D1%82%D0%B0%D0%BD%D0%B0%D0%BC%D0%BE

Comment 5

[Phoenix]

Problem still present, in both History and Bookmarks location shows http://ru.wikipedia.org/wiki/%D0%92%D0%BE%D0%B5%D0%BD%D0%BD%D0%B0%D1%8F_%D0%B1%D0%B0%D0%B7%D0%B0_%D0%93%D1%83%D0%B0%D0%BD%D1%82%D0%B0%D0%BD%D0%B0%D0%BC%D0%BE instead of http://ru.wikipedia.org/wiki/Военная база Гуантанамо