Closed
Bug 479973
Opened 15 years ago
Closed 15 years ago
Agenda List Box Item in Today Pane is always white, when selected and deactivated
Categories
(Calendar :: Calendar Frontend, defect)
Calendar
Calendar Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
1.0b1
People
(Reporter: eldeh, Assigned: sipaq)
Details
Attachments
(1 file)
1.35 KB,
patch
|
berend.cornelius09
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.8.1.14) Gecko/20080410 SUSE/2.0.0.14-0.1 Firefox/2.0.0.14 Build Identifier: Thunderbird 2.0.014, Lightning 0.9 In the Today Pane (Agenda - Appointments), the background of selected list items is always white, when the pane is not active. In a dark color scheme with white text color, this is annoying. Reproducible: Always today-pane.css should perhaps be altered: .agenda-container-box[selected="true"][disabled="true"], .agenda-allday-container-box[selected="true"][disabled="true"], .agenda-checkbox[selected="true"][disabled="true"] { background-image: none; color: -moz-dialogText; background-color: white; // <--- HERE } Color is not hard-coded, so background color should also not be.
Assignee | ||
Comment 1•15 years ago
|
||
Assignee: nobody → bugzilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #363910 -
Flags: review?
Assignee | ||
Updated•15 years ago
|
Attachment #363910 -
Flags: review? → review?(berend.cornelius09)
Also in today-pane.css, the foreground-color is also not set in the section: .agenda-container-box[current="true"], .agenda-alldaycontainer-box[current="true"], .agenda-checkbox[current="true"], .agenda-container-box[selected="true"][current="true"][disabled="true"], .agenda-allday-container-box[selected="true"][current="true"][disabled="true"], .agenda-checkbox[selected="true"][current="true"][disabled="true"] { background-image: url("chrome://mozapps/skin/extensions/itemEnabledFader.png"); background-color: #DFEAF4; // <-- here only a bright background is set } It would be perhaps better, to set the background not directly to a certain color or to set a dark text color also. Otherwise in a dark color scheme, white is used as text color on this bright background.
Comment 3•15 years ago
|
||
Comment on attachment 363910 [details] [diff] [review] Patch v1 >- background-color: white; >+ background-color: -moz-dialog; This means the background color will be gray, not sure this is what we want?
Comment 4•15 years ago
|
||
FWIW, background-color: transparent !important; works well on my computer.
Comment 5•15 years ago
|
||
Comment on attachment 363910 [details] [diff] [review] Patch v1 patch is Ok and looks good under Linux. I haven't looked at other platforms.
Attachment #363910 -
Flags: review?(berend.cornelius09) → review+
Assignee | ||
Comment 6•15 years ago
|
||
Revision bd89a174f1c7 pushed to comm-central --> FIXED
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
OS: Linux → All
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Updated•15 years ago
|
Hardware: x86 → All
Updated•14 years ago
|
Target Milestone: 1.0 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•