479973 - Agenda List Box Item in Today Pane is always white, when selected and deactivated

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[eldeh]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de; rv:1.8.1.14) Gecko/20080410 SUSE/2.0.0.14-0.1 Firefox/2.0.0.14
Build Identifier: Thunderbird 2.0.014, Lightning 0.9

In the Today Pane (Agenda - Appointments), the background of selected list items is always white, when the pane is not active. In a dark color scheme with white text color, this is annoying.

Reproducible: Always




today-pane.css should perhaps be altered:


.agenda-container-box[selected="true"][disabled="true"],
.agenda-allday-container-box[selected="true"][disabled="true"],
.agenda-checkbox[selected="true"][disabled="true"] {
  background-image: none;
  color: -moz-dialogText;
  background-color: white;   // <--- HERE
}


Color is not hard-coded, so background color should also not be.

Comment 1

[Simon Paquet [:sipaq]]

Attachment: Patch v1

Comment 2

[eldeh]

Also in today-pane.css,

the foreground-color is also not set in the section:

.agenda-container-box[current="true"],
.agenda-alldaycontainer-box[current="true"],
.agenda-checkbox[current="true"],
.agenda-container-box[selected="true"][current="true"][disabled="true"],
.agenda-allday-container-box[selected="true"][current="true"][disabled="true"],
.agenda-checkbox[selected="true"][current="true"][disabled="true"] {
  background-image: url("chrome://mozapps/skin/extensions/itemEnabledFader.png");
  background-color: #DFEAF4;   // <-- here only a bright background is set
}

It would be perhaps better, to set the background not directly to a certain color or to set a dark text color also. Otherwise in a dark color scheme, white is used as text color on this bright background.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 363910 [details] [diff] [review]
Patch v1


>-  background-color: white;
>+  background-color: -moz-dialog;

This means the background color will be gray, not sure this is what we want?

Comment 4

[Pete Riley]

FWIW, background-color: transparent !important;
works well on my computer.

Comment 5

[Berend Cornelius]

Comment on attachment 363910 [details] [diff] [review]
Patch v1

patch is Ok and looks good under Linux. I haven't looked at other platforms.

Comment 6

[Simon Paquet [:sipaq]]

Revision bd89a174f1c7 pushed to comm-central

--> FIXED